Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document lld needs -Wl,--no-threads on Windows, fix our build systems #897

Closed
DanAlbert opened this issue Jan 28, 2019 · 1 comment
Closed

document lld needs -Wl,--no-threads on Windows, fix our build systems #897

DanAlbert opened this issue Jan 28, 2019 · 1 comment
Assignees
@DanAlbert
Milestone
r19b

Comments

@DanAlbert
Copy link
Member

#855

We should fix ndk-build, the CMake toolchain, and standalone toolchains to disable threads by default for Windows (I'm fairly certain this is Windows specific, I haven't seen it and that's where the two reports came from) and mark this as a KI in our changelog/build system maintainers docs.
@DanAlbert DanAlbert added this to the r19b milestone Jan 28, 2019
@DanAlbert DanAlbert self-assigned this Jan 28, 2019
@DanAlbert DanAlbert mentioned this issue Jan 28, 2019
Closed
@DanAlbert
Copy link
Member Author

DanAlbert commented Feb 9, 2019 •
edited
Loading

Fix for ndk-build and docs are merged. Can't fix CMake because we don't have the information in the toolchain file and not fixing standalone toolchains because they shouldn't diverge from the non-wrapped compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
None yet
Projects
None yet
Milestone
r19b
Development

No branches or pull requests
1 participant
@DanAlbert