[BUG] neither ndk-build nor CMake toolchain file uses --gc-sections for shared libraries by default
#1717
Assignees
Labels
Comments
osspop
pushed a commit
to osspop/android-ndk
that referenced
this issue
Jan 17, 2023
git auto resolved this conflict by ignoring the file entirely, it seems, so the test is still marked as broken despite the fix that was cherry- picking having deleted this file... Bug: android/ndk#1717 Test: ./run_tests.py --filter gc_sections --rebuild Change-Id: I52bf37c72bba7f8e439a26ed9c5985299d71ef8e (cherry picked from commit 20341934576c924d1700ca20b396e564843f8abd) Merged-In: I52bf37c72bba7f8e439a26ed9c5985299d71ef8e
osspop
pushed a commit
to osspop/android-ndk
that referenced
this issue
Jan 17, 2023
Bug: android/ndk#1717 Test: this is the test Change-Id: Ia71d3137a34e2812a7ed4d37d54175a24e714ea9
osspop
pushed a commit
to osspop/android-ndk
that referenced
this issue
Jan 17, 2023
git auto resolved this conflict by ignoring the file entirely, it seems, so the test is still marked as broken despite the fix that was cherry- picking having deleted this file... Bug: android/ndk#1717 Test: ./run_tests.py --filter gc_sections --rebuild Change-Id: I52bf37c72bba7f8e439a26ed9c5985299d71ef8e (cherry picked from commit 20341934576c924d1700ca20b396e564843f8abd) Merged-In: I52bf37c72bba7f8e439a26ed9c5985299d71ef8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Neither ndk-build nor CMake toolchain file uses
--gc-sectionsfor shared libraries by default (they both do for executables). This is contrary to our own docs: https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Controlling-Binary-SizeThis seems to have always been the case (checking all the way back to r10 shows the same behavior). I'm not sure if the author back then did that intentionally or if it was an oversight, but afaik there's no downside to using this flag, so it should be on by default.
Test case
Affected versions
r23, r24, r25, Canary
Canary version
TOT
Host OS
Linux, Mac, Windows
Host OS version
all
Affected ABIs
armeabi-v7a, arm64-v8a, x86, x86_64
Build system
CMake
Other build system
No response
minSdkVersion
any
Device API level
N/A
The text was updated successfully, but these errors were encountered: