Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarcodeScanner implements LifecycleObserver, but close is called manually #588

Open
AlexTrotsenko opened this issue Jul 29, 2024 · 0 comments

Comments

@AlexTrotsenko
Copy link

AlexTrotsenko commented Jul 29, 2024

Assuming, that the idea of samples is to show best practice of using ML KIT sdk, I would suggest to replace manual call to .close() by lifecycle.addObserver(barcodeScanner).

However if there is a reason not to do so - could you please explain it either in readme or via the comment in the code for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant