-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ndk-bundle disappeared (a good thing, but confusing) #321
Comments
Silent warning fix, my favorite fix, but seriously, I understand why it would raise concerns. ndk-bundle used to come preinstalled by GitHub as part of the Virtual Environment. They "deprecated" it on July 24th, but it takes a few days for changes to propagate to all hosted runners. actions/runner-images#5879 I should update README.md to explain that we try to find preinstalled sdk and update or install one if no good preinstalled was found. |
(I had to fix this because I was running 100s of Gradle builds in unit tests for a Gradle plugin, so it was warning and polluting my test logs.) Thanks for the explanation, that totally makes sense. I like how a "deprecation" by GitHub terminology can break builds :) |
I'm closing this issue. I assume this is solved |
Yep, more of a heads-up / discussion. |
Hi, I'm using your action for a while now, and it has always warned about ndk-bundle being in the wrong location. (e.g. you can see it here too #167)
I even tried different workarounds to silence the warning:
then
now, the weird thing is that recently it suddenly disappeared. 9 days ago (July 27) it was working (i.e. the folder was there and deleting it worked), but then July 29, and August 3 I had failing builds because it was unable to find this directory / symlink to delete.
So I just disabled this step and the warning seems to be gone:
Now, don't get me wrong, I like this state better, it's just curious that you didn't release a
setup-android@v2
version around these dates (last release 2.0.8 on April 22, and tag v2 points to that commit too), yet the behavior changed, any idea why?The text was updated successfully, but these errors were encountered: