Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated sites does not show properly in TLS only environments #50

Open
ottlinger opened this issue Jun 3, 2016 · 2 comments
Open

Comments

@ottlinger
Copy link

Having generated a site with version 1.1.1 yields a broken layout if shown in a browser with httpseverywhere, since the links to

  • JQuery
  • Bootstrap
  • html5shim
    are http only.

Either they should be changed to https or a configuration option could be added that allows locally downloaded versions to avoid the mix of http and https.

The following links provoke the problem:

<link href="http://netdna.bootstrapcdn.com/bootswatch/2.3.2/cosmo/bootstrap.min.css" rel="stylesheet" />
<link href="http://netdna.bootstrapcdn.com/twitter-bootstrap/2.3.1/css/bootstrap-responsive.min.css" rel="stylesheet" />
<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script src="http://netdna.bootstrapcdn.com/twitter-bootstrap/2.3.2/js/bootstrap.min.js"></script>

Changing them to https works fine:

Which way would you prefer?

  • configuration option to enable SSL and providing html5.js with a relative link?
  • configuration option to have all external references locally and use relative links?

The simplest option would be to change all above links to https and provide a local copy of htlm5shim - shall I start a pull request?

Thanks

@bindul
Copy link

bindul commented Dec 8, 2016

@ottlinger,

Have you looked at the local resources option, documented at http://andriusvelykis.github.io/reflow-maven-skin/skin/resources.html?

  • Bindul

@llorllale
Copy link

llorllale commented Sep 23, 2017

+1

Although I was able to workaround this using protocolRelativeURLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants