Spring refactoring

[andreyorst]

Spring is all on it's way, birds sing, blossoms grow, code is being rewritten.

Some critical moments need to be visited:

• There's now a centralized way to handle terminal windows outside of tmux, with terminal command that should be used instead of termcmd option. This will fix [Feature Request] support iterm outside of tmux #40. Althought this may require to fully rewrite fzf.kak, I was planning to do it anyway.
• My fzf command is ugly af. Argument handling is painful and other things are way too complicated, which results in really awkward methods of writing supplement scripts. I suppose a full featured argument parsing algorithm will clean this mess up.
• Something should be done with getting of the output of fzf

[elasticdog]

Just wanted to say thank you for your work on fzf.kak, and that I'm excited to see the refactoring work. Similar to #40, I'm using a different terminal emulator (kitty), and refactoring to use the standard terminal aliases without assuming tmux would make a huge difference for my workflow. I know there are others out there with the same setup that have struggled: mawww/kakoune#2266 (comment)

It sounds like you have a good plan for the cleanup, but please let me know if you'd like a hand or just another set of eyes on the proposed changes. Cheers!

[andreyorst]

I've tested fzf.kak on kitty, it should work without tmux just fine. What difficulties do you have?

Edit:
Oh, and thanks for your feedback! I highly appreciate it. But you know, issues first, feelings second 😺

[elasticdog]

Just that it opens a new os window type rather than a normal Kitty window (which is the default behavior of kitty @ new-window), so it's a little slow and jarring, and then when fzf is complete, the window goes away and focus is not returned to the editor. It functionally works, but it's not as nice as the tmux split behavior, if that makes sense?

[andreyorst]

Strange, just installed kitty and It works.

$ kitty -v
kitty 0.13.3 created by Kovid Goyal
$ kak -version
Kakoune v2019.01.20-109-g017b7c97

Well, my kakoune might be bit outdated, maybe recent changes broken something.

Edit:
Nope, just updated Kakoune to Kakoune v2019.01.20-128-gf87e8442 and fzf.kak still works with Kitty. @elasticdog can you please open a separate issue, and provide more information about your environment?

[laelath]

It's working fine, it's just calling x11 to open a new window. Something that kitty does is have it's own internal windows that the kakoune kitty support allows you to use.

Here's what's currently happening:

Here would be a desired outcome:

With fzf taking the place of the right kakoune window.

Which is precisely what rewriting fzf.kak to use the builtin terminal alias would do.

[andreyorst]

it's just calling x11 to open a new window.

Well it was a design choice to support terminals via X11, because there are plenty of those which allow splitting (terminator, konsole, iTerm2, tilix, etc), and I can't support them all in terms of creating splits of desired size, like I do in tmux. If something like mawww/kakoune#1363 will be more flexible and will accept size and side via arguments, it will be more flexible in the future.