From 56836d4d4735e086063d89baf3dd17bce64b3406 Mon Sep 17 00:00:00 2001 From: "Bohao(Aaron) Wang" Date: Fri, 24 May 2019 14:00:18 -0400 Subject: [PATCH] Delete bndsChkNeedsLiteralFromPool function from OMR This patch deletes all references to the function bndsChkNeedsLiteralFromPool in OMR. Closes: #1872 Signed-off-by: Bohao(Aaron) Wang --- compiler/codegen/OMRCodeGenerator.hpp | 1 - compiler/z/codegen/OMRCodeGenerator.cpp | 17 ----------------- compiler/z/codegen/OMRCodeGenerator.hpp | 2 -- 3 files changed, 20 deletions(-) diff --git a/compiler/codegen/OMRCodeGenerator.hpp b/compiler/codegen/OMRCodeGenerator.hpp index 17f52732e5d..11c06efc8b7 100644 --- a/compiler/codegen/OMRCodeGenerator.hpp +++ b/compiler/codegen/OMRCodeGenerator.hpp @@ -1328,7 +1328,6 @@ class OMR_EXTENSIBLE CodeGenerator // symbol reference requires entry in the literal pool bool arithmeticNeedsLiteralFromPool(TR::Node *node) { return false; } bool bitwiseOpNeedsLiteralFromPool(TR::Node *parent, TR::Node *child) { return false; } - bool bndsChkNeedsLiteralFromPool(TR::Node *node) { return false; } void setOnDemandLiteralPoolRun(bool answer) {} bool isLiteralPoolOnDemandOn () { return false; } bool supportsOnDemandLiteralPool() { return false; } diff --git a/compiler/z/codegen/OMRCodeGenerator.cpp b/compiler/z/codegen/OMRCodeGenerator.cpp index 99faee42a6a..99c44fd1c15 100644 --- a/compiler/z/codegen/OMRCodeGenerator.cpp +++ b/compiler/z/codegen/OMRCodeGenerator.cpp @@ -4486,23 +4486,6 @@ OMR::Z::CodeGenerator::supportsOnDemandLiteralPool() } } -/** - * Check if BNDS check should use a CLFI - */ -bool -OMR::Z::CodeGenerator::bndsChkNeedsLiteralFromPool(TR::Node *node) - { - int64_t value=getIntegralValue(node); - - if (value <= GE_MAX_IMMEDIATE_VAL && value >= GE_MIN_IMMEDIATE_VAL) - { - return false; - } - else - { - return true; - } - } TR::Register * OMR::Z::CodeGenerator::evaluateLengthMinusOneForMemoryOps(TR::Node *node, bool clobberEvaluate, bool &lenMinusOne) { diff --git a/compiler/z/codegen/OMRCodeGenerator.hpp b/compiler/z/codegen/OMRCodeGenerator.hpp index 01e511e2def..7afd7a41a49 100644 --- a/compiler/z/codegen/OMRCodeGenerator.hpp +++ b/compiler/z/codegen/OMRCodeGenerator.hpp @@ -797,8 +797,6 @@ class OMR_EXTENSIBLE CodeGenerator : public OMR::CodeGenerator // LL: move to .cpp bool bitwiseOpNeedsLiteralFromPool(TR::Node *parent, TR::Node *child); - bool bndsChkNeedsLiteralFromPool(TR::Node *child); - virtual bool isDispInRange(int64_t disp); bool getSupportsOpCodeForAutoSIMD(TR::ILOpCode, TR::DataType);