Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have layout react to pin layout field in HardwareDescription #397

Closed
andrewdavidmackenzie opened this issue Aug 27, 2024 · 5 comments · Fixed by #509
Closed

Have layout react to pin layout field in HardwareDescription #397

andrewdavidmackenzie opened this issue Aug 27, 2024 · 5 comments · Fixed by #509
Assignees

Comments

@andrewdavidmackenzie
Copy link
Owner

RPi pins alternate 1 on left, 2 on right and so on, so 40 is bottom left
Pico physical pins could 1-20 down left side, then 21-40 UP right side, with 40 top right

Thus, for the board layout to be correct, we need to do it differently for RPi and Pico.

We should send the layout as a field in HardwareDescription and then change the layout view to do one way or the other.

@andrewdavidmackenzie
Copy link
Owner Author

andrewdavidmackenzie commented Aug 30, 2024

I have added this field: PinLayoutScheme in the HardwareDescription for pi_hw, fake_hw and porky in my pico-piglet branch.

@sundaram123krishnan would you like to work on the hardware layout view in this branch, changing how pins are laid out according to that field?

If you do, please try to DRY-up the code, and re-use as much as possible.... maybe just modifying how the row pair using chunks is created...and keeping all the rest the same?

@andrewdavidmackenzie
Copy link
Owner Author

andrewdavidmackenzie commented Aug 30, 2024

Pi Pico layout using the CounterClockwise scheme

pi_pico_w_pinout

@andrewdavidmackenzie
Copy link
Owner Author

Pi layout, using the Rows scheme

pi

@sundaram123krishnan
Copy link
Collaborator

Will do @andrewdavidmackenzie

@andrewdavidmackenzie andrewdavidmackenzie changed the title Add pin layout field to HardwareDescription and change layout accordingly Have layout react to pin layout field in HardwareDescription Sep 20, 2024
@andrewdavidmackenzie
Copy link
Owner Author

This would be required prior to announcing/releasing Pico support is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants