Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to hide battery replaced button/sensor #167

Closed
3 tasks done
andrew-codechimp opened this issue Dec 28, 2023 · 3 comments · Fixed by #173
Closed
3 tasks done

Add config option to hide battery replaced button/sensor #167

andrew-codechimp opened this issue Dec 28, 2023 · 3 comments · Fixed by #173
Assignees
Labels
enhancement New feature or request

Comments

@andrew-codechimp
Copy link
Owner

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

Some people don't want this functionality and confuses when devices have had the button pressed x years ago

Describe the solution you'd like

Add a config option to disable showing of battery replaced, enabled by default

Describe alternatives you've considered

None

Additional context

None

@uvjim
Copy link
Contributor

uvjim commented Dec 30, 2023

Does this need to be an option? The entity description allows you as a developer to define the behaviour and the UI allows the user to either enable or disable an entity as required.

I guess all you need to do is decide whether they should be enabled by default or not and then users can decide after that on an entity by entity basis.

@andrew-codechimp
Copy link
Owner Author

After looking into it that's exactly what I'm doing now. I've never really disabled entities much myself so didn't occur to me straight away.

@andrew-codechimp andrew-codechimp linked a pull request Dec 30, 2023 that will close this issue
@andrew-codechimp
Copy link
Owner Author

Released in version 1.3.4.
See the FAQ for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants