Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external datasource #33

Open
haseelrefl opened this issue Sep 18, 2018 · 5 comments
Open

Add support for external datasource #33

haseelrefl opened this issue Sep 18, 2018 · 5 comments
Assignees

Comments

@haseelrefl
Copy link

First of all let me thank you for the awesome library. It just saved me lots of code and helped keep things neat.

One feature I think would add value is option to add an external datasource other than App's Bundle. So, we could read from JSON files that is in application's documents directory. This helps to make the localisation files dynamic.

A simple use case would be the ability to push any changes to the strings to the app from server. The app could just replace contents in the documents directory. I am assuming we cannot alter contents in the Bundle. Correct me if I am wrong.

@andresilvagomez
Copy link
Owner

@haseelrefl I really so sorry I know its so late, but yes you are right, I'll work in this feature today, I'll back soon when I have some news.

@andresilvagomez andresilvagomez self-assigned this Oct 22, 2018
@haseelrefl
Copy link
Author

Thanks for the update. Great that you are able to work on the feature. It would be of great use. (Y)

@x2web
Copy link

x2web commented Feb 11, 2019

I preload localization to Dictionary:[String:String] from file in Documents Cache folder if it exists, or default from bundle. And then I use localize from dictionary.

@prakshapan
Copy link

prakshapan commented Apr 1, 2019

How do i load localization from application's documents directory? All i could find was from Bundle.

@marcoserafini2
Copy link

I preload localization to Dictionary:[String:String] from file in Documents Cache folder if it exists, or default from bundle. And then I use localize from dictionary.

@x2web How did you do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants