From 51e781d8f13c3027d36739b784f43ba7f3ef1234 Mon Sep 17 00:00:00 2001 From: Andrei Matei Date: Tue, 5 Jun 2018 16:30:44 -0400 Subject: [PATCH] kv: skip TestTxnCoordSenderRetries TestTxnCoordSenderRetries is flaky, presumably as a consequence of merging #25541. A subtest is sometimes failing because a CommandFilter that it's using is inadvertently injecting a failure into a lingering request from a previous subtest. Don't know why that PR changed any behavior yet, but it seems more likely that this is a test issue than issue warranting a rollback, so skipping while I figure it out. Touches #26434 Release note: None --- pkg/kv/dist_sender_server_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/kv/dist_sender_server_test.go b/pkg/kv/dist_sender_server_test.go index 21de65a9dd12..c329ad99d9d9 100644 --- a/pkg/kv/dist_sender_server_test.go +++ b/pkg/kv/dist_sender_server_test.go @@ -1871,6 +1871,7 @@ func TestTxnCoordSenderHeartbeatFailurePostSplit(t *testing.T) { // but still fail in others, depending on different conditions. func TestTxnCoordSenderRetries(t *testing.T) { defer leaktest.AfterTest(t)() + t.Skip("26434") var filterFn atomic.Value var storeKnobs storage.StoreTestingKnobs