Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the RRDBNet correct? #52

Open
vagrant3427 opened this issue Mar 17, 2022 · 0 comments
Open

Is the RRDBNet correct? #52

vagrant3427 opened this issue Mar 17, 2022 · 0 comments

Comments

@vagrant3427
Copy link

vagrant3427 commented Mar 17, 2022

In the forward function of the RRDBNet

def forward(self, x, get_steps=False):
    fea = self.conv_first(x)
    block_idxs = opt_get(self.opt, ['network_G', 'flow', 'stackRRDB', 'blocks']) or []
    block_results = {}
    for idx, m in enumerate(self.RRDB_trunk.children()):            
        fea = m(fea)                                               
        for b in block_idxs:
            if b == idx:
                block_results["block_{}".format(idx)] = fea         
    trunk = self.trunk_conv(fea)
    last_lr_fea = fea + trunk             

It seems that fea in the last_lr_fea=fea+trunk line is the feature of the last RRDB block before self.turnk_conv. But to my knowledge, the skip connection should be last_lr_fea = x+ trunk. Is my understanding right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant