You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Missing test workflow for python 2.7. In the past trash-cli supported both python 2.7 and the newer versions of python 3.x leveraging the Git Hub Actions support. Recently Git Hub Action dropped the support of python 2.7 and so we no longer have a way to test the code automatically on Python 2.7.
To Reproduce
Fork the project in your GitHub
Enable Git Hub Actions on your repository
Launch the actions and verify it no longer execute on python 2.7
Edit .github/workflows/run-tests.yml and add '2.7' to the python versions
Save, commit and push and see that is failing because 2.7 is not supported
Expected behavior
That have a way to launch tests on every commit on python 2.7 like the old days.
Probably is just a matter of running an action on a custom image based on an LTS distribution that still provide support for python 2.7. (For me) it is not an easy task.
I hope that someone skilled can contribute a solution.
The text was updated successfully, but these errors were encountered:
Have you considered dropping support for Python 2? It would instantly solve this issue and furthermore allow you to clean up all those future imports and write more modern and cleaner code.
Considering security support for Python 2 ended almost 5 years ago, I'd call it very end of life. If people out there absolutely need to use it with Python 2, I'd say it's their problem to backport patches and test it.
Describe the bug
Missing test workflow for python 2.7. In the past trash-cli supported both python 2.7 and the newer versions of python 3.x leveraging the Git Hub Actions support. Recently Git Hub Action dropped the support of python 2.7 and so we no longer have a way to test the code automatically on Python 2.7.
To Reproduce
.github/workflows/run-tests.yml
and add '2.7' to the python versionspython-version: ['2.7', '3.7', '3.8', '3.9', '3.10', '3.11']
Expected behavior
That have a way to launch tests on every commit on python 2.7 like the old days.
Probably is just a matter of running an action on a custom image based on an LTS distribution that still provide support for python 2.7. (For me) it is not an easy task.
I hope that someone skilled can contribute a solution.
The text was updated successfully, but these errors were encountered: