Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Testing on Python 2.7 #313

Open
andreafrancia opened this issue Sep 22, 2023 · 2 comments
Open

Continuous Testing on Python 2.7 #313

andreafrancia opened this issue Sep 22, 2023 · 2 comments

Comments

@andreafrancia
Copy link
Owner

Describe the bug
Missing test workflow for python 2.7. In the past trash-cli supported both python 2.7 and the newer versions of python 3.x leveraging the Git Hub Actions support. Recently Git Hub Action dropped the support of python 2.7 and so we no longer have a way to test the code automatically on Python 2.7.

To Reproduce

  • Fork the project in your GitHub
  • Enable Git Hub Actions on your repository
  • Launch the actions and verify it no longer execute on python 2.7
  • Edit .github/workflows/run-tests.yml and add '2.7' to the python versions
    • e.g.python-version: ['2.7', '3.7', '3.8', '3.9', '3.10', '3.11']
  • Save, commit and push and see that is failing because 2.7 is not supported

Expected behavior
That have a way to launch tests on every commit on python 2.7 like the old days.

Probably is just a matter of running an action on a custom image based on an LTS distribution that still provide support for python 2.7. (For me) it is not an easy task.

I hope that someone skilled can contribute a solution.

@dreua
Copy link
Contributor

dreua commented Nov 8, 2024

Have you considered dropping support for Python 2? It would instantly solve this issue and furthermore allow you to clean up all those future imports and write more modern and cleaner code.

Considering security support for Python 2 ended almost 5 years ago, I'd call it very end of life. If people out there absolutely need to use it with Python 2, I'd say it's their problem to backport patches and test it.

@andreafrancia
Copy link
Owner Author

If I find a potentially dangerous bug I wish to be able to distribute the fix also to the people that are stuck with a legacy distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants