From 409c1a451edb6fe79b3c920c02c213acbb9a755d Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Mon, 13 Nov 2023 15:21:54 -0800 Subject: [PATCH] Restore default for column_valued name parameter Commit 20436f71520e26e1f6fd81836ee7e283d69db8df (#258) incorrectly removed this default, which is needed to accept calls without a name, i.e., .column_valued(). Fixes #259. Signed-off-by: Anders Kaseorg --- sqlalchemy-stubs/sql/functions.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sqlalchemy-stubs/sql/functions.pyi b/sqlalchemy-stubs/sql/functions.pyi index 136d9bc..5fce9c3 100644 --- a/sqlalchemy-stubs/sql/functions.pyi +++ b/sqlalchemy-stubs/sql/functions.pyi @@ -59,7 +59,7 @@ class FunctionElement( # type: ignore[misc] ) -> ScalarFunctionColumn[_TE]: ... def table_valued(self, *expr: Any, **kw: Any) -> TableValuedAlias: ... # type: ignore[override] def column_valued( - self, name: Optional[Any], joins_implicitly: bool = False + self, name: Optional[Any] = ..., joins_implicitly: bool = False ) -> TableValuedColumn[Any]: ... @property def columns(self) -> ColumnCollection[ColumnElement[Any]]: ... # type: ignore[override]