Syft panics in docker and mounting docker socket with some images

[iperalta7]

What happened:

Syft image throws me a panic when trying to parse an image

$ docker run --rm -v /var/run/docker.sock:/var/run/docker.sock anchore/syft --catalogers dpkgdb --output cyclonedx-json python:latest
panic: value method github.com/anchore/syft/syft/source.StereoscopeImageSource.Close called using nil *StereoscopeImageSource pointer

goroutine 38 [running]:
github.com/anchore/syft/syft/source.(*StereoscopeImageSource).Close(0xc0000e1c40?)
	<autogenerated>:1 +0x86
github.com/anchore/syft/cmd/syft/cli/packages.execWorker.func1()
	/home/runner/work/syft/syft/cmd/syft/cli/packages/packages.go:109 +0x92a
created by github.com/anchore/syft/cmd/syft/cli/packages.execWorker
	/home/runner/work/syft/syft/cmd/syft/cli/packages/packages.go:57 +0xf7

What you expected to happen:

I am expecting this to run without error and stddout the cyclonedx-json, like I would get for some images. It should give me the output like this command would: docker run --rm anchore/syft --catalogers dpkgdb --output cyclonedx-json python:latest

Steps to reproduce the issue:

Run this command:
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock anchore/syft --catalogers dpkgdb --output cyclonedx-json docker:python:latest

This seems to not work for python:latest, ruby:latest, golang:latest and a couple other images for me, so the image name can be messed around with to show that it works for some other images.

Anything else we need to know?:

Running the command without the docker socket will work however.
docker run --rm anchore/syft --catalogers dpkgdb --output cyclonedx-json python:latest

Environment:

• Output of syft version:

Version:            0.85.0
JsonSchemaVersion:  9.0.0
BuildDate:          2023-07-12T17:14:54Z
GitCommit:          4fc17edd146af34ab06f5b0443ef8ddac3aaf076
GitDescription:     [not provided]
Platform:           darwin/amd64
GoVersion:          go1.20.6
Compiler:           gc

• OS (e.g: cat /etc/os-release or similar):

macOS Ventura 13.5

• Docker Version

Client:
 Cloud integration: v1.0.33
 Version:           24.0.2
 API version:       1.43
 Go version:        go1.20.4
 Git commit:        cb74dfc
 Built:             Thu May 25 21:51:16 2023
 OS/Arch:           darwin/amd64
 Context:           desktop-linux

Server: Docker Desktop 4.20.1 (110738)
 Engine:
  Version:          24.0.2
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.4
  Git commit:       659604f
  Built:            Thu May 25 21:52:17 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.21
  GitCommit:        3dce8eb055cbb6872793272b4f20ed16117344f8
 runc:
  Version:          1.1.7
  GitCommit:        v1.1.7-0-g860f061
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

[iperalta7]

@telday

[tgerla]

Hey @iperalta7, thanks for the report. I'm unable to reproduce this immediately on my system. (macOS Ventura 13.4.1, Docker Desktop 4.21.1). Can you open up Docker and go to Settings -> Advanced and tell us what your settings are? For example, I've attached mine.

Thanks!

[iperalta7]

Hey! Here is a screenshot:

[tgerla]

Hmm, OK. I am not a Docker expert here but what do you see if you run the following?

ls -la /var/run/docker.sock

[iperalta7]

With the help of an associate, I can say this is indeed more of a local issue. But even after reinstallation of both docker and syft, it still occurs.

That command gives me:
lrwxr-xr-x@ 1 root daemon 45 Aug 3 09:49 /var/run/docker.sock -> /Users/isaiah.peralta/.docker/run/docker.sock

[wagoodman]

@iperalta7 Looks like you're on v0.85.0, try updating to at least v0.86.0 or higher, we fixed this in #1968 and released in https://github.com/anchore/syft/releases/tag/v0.86.0 . If you still see this please shout out and we can re-open it.