Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[popOver] Should add maxHeight if popOver won't fit at all #745

Open
IanCStewart opened this issue Jun 21, 2017 · 1 comment
Open

[popOver] Should add maxHeight if popOver won't fit at all #745

IanCStewart opened this issue Jun 21, 2017 · 1 comment

Comments

@IanCStewart
Copy link
Contributor

IanCStewart commented Jun 21, 2017

popOver's that won't fit on top or bottom get aligned in the middle now. If a popOver is bigger than the window height you're missing both top and bottom of the popOver.

this seems weird...

@IanCStewart IanCStewart changed the title [popOver] Should add maxHeight if popOver if it doesn't fit at all [popOver] Should add maxHeight if popOver won't fit at all Sep 14, 2017
@sjaakluthart sjaakluthart added this to the 5.0.0 milestone Oct 6, 2017
@IanCStewart
Copy link
Contributor Author

Partial fix in branch issue-#745. Seems to work initially until u resize to a bigger screen. This happens because the ref.height uses the old height and not the rendered height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants