Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightbox] Headerprops primaryText should be required #123

Open
larstadema opened this issue Jul 20, 2018 · 0 comments
Open

[Lightbox] Headerprops primaryText should be required #123

larstadema opened this issue Jul 20, 2018 · 0 comments

Comments

@larstadema
Copy link
Contributor

The lightbox component cannot render without headerProps, specifically the primaryText.

There is no check if a header should be rendered and neither what the title text should be.

I think the best solution would be to add a title prop that is required and passed to header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant