Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot read properties of undefined (reading 'some') in v6.0.3 #195

Closed
dargmuesli opened this issue Sep 23, 2024 · 5 comments · Fixed by #196
Closed

fix: cannot read properties of undefined (reading 'some') in v6.0.3 #195

dargmuesli opened this issue Sep 23, 2024 · 5 comments · Fixed by #196

Comments

@dargmuesli
Copy link
Contributor

Hmm, I think something broke with v6.0.3:

image

Seems like this .some here works differently now: 5199d86

@clshortfuse
Copy link
Collaborator

clshortfuse commented Sep 24, 2024

Do you have a reproducible? The last commit on that file is https://github.com/anandthakker/doiuse/blob/14b4c0d128b1fb1f45619aa5db87417b8b2292b4/data/features/flexbox-gap.js
and it has a check for .some

if (!('some' in rule)) return false;

Edit: seems the issue relates to this.nodes.some inside postcss

@dargmuesli
Copy link
Contributor Author

Correct, this.nodes is empty (while some is fine). I haven't created a reproducible myself yet, but the screenshot comes from this renovate PR which updated doiuse to v6.0.3: https://github.com/dargmuesli/vio/actions/runs/11005452662/job/30558159103?pr=233#step:7:826
I'll come back to this when time allows 🏃

@dargmuesli
Copy link
Contributor Author

Added a fix in #196 🙌

@MuTsunTsai
Copy link

Having the same issue with the same cause. Looking forward for the fix.

@dargmuesli
Copy link
Contributor Author

Fyi @clshortfuse it seems the last release was not tagged on GitHub and therefore there is also no release visible. Maybe that's on your radar already, I just want to mention it in case it isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants