Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): plugin causing build failures in version migration #961

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

choyiny
Copy link
Contributor

@choyiny choyiny commented Mar 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

A weird edge case with projects migrating from Angular v16 and Analog v0.2 causes builds to fail after upgrading:

An unhandled exception occurred: [@analogjs/vite-plugin-nitro] [@analogjs/vite-plugin-angular] Cannot read properties of undefined (reading 'Error')

This is due to ts.DiagnosticCategory being resolved to undefined instead of the actual Typescript Enum in typescript.d.ts. However, I was not able to find the reason behind this.

What is the new behavior?

If ts.DiagnosticCategory is undefined, skip propagating errors and warnings in createFileEmitter.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit eec48c4
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65ff8a804afd460008d8e81f
😎 Deploy Preview https://deploy-preview-961--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit eec48c4
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65ff8a805c8b58000884e99f
😎 Deploy Preview https://deploy-preview-961--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit eec48c4
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65ff8a80b06c8a000820dbd4
😎 Deploy Preview https://deploy-preview-961--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit eec48c4
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65ff8a80d019b80008334106
😎 Deploy Preview https://deploy-preview-961--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts changed the base branch from main to beta March 24, 2024 02:22
@brandonroberts brandonroberts merged commit e020700 into analogjs:beta Mar 24, 2024
22 of 23 checks passed
@choyiny choyiny deleted the vite-plugin-edgecase branch March 24, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants