Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-nitro): forward HTTP headers to the API endpoint #893

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

omarbelkhodja
Copy link
Contributor

PR Checklist

PR Type

  • [ x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • [ x ] vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

The HTTP headers are not tranmitted to the API endpoints.

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [ x ] No

Other information

We are using cookies in our application, and there are some cases where cookies are not transmitted to the backend, during SSR rendering (for example, the default resolver doesn't transmit the cookies). The minimal modification we need for now is the one inside this PR.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit fc69a15
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65cccd04f02e9d0008092fc6
😎 Deploy Preview https://deploy-preview-893--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit fc69a15
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65cccd047c8b1600083db251
😎 Deploy Preview https://deploy-preview-893--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for analog-app failed.

Name Link
🔨 Latest commit fc69a15
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65cccd04f492980008ecfc84

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for analog-ng-app failed.

Name Link
🔨 Latest commit fc69a15
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65cccd04ced6d00008bd11ca

@brandonroberts brandonroberts merged commit c998e81 into analogjs:main Feb 14, 2024
14 of 23 checks passed
@brandonroberts
Copy link
Member

Thanks! Released in 0.2.37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants