Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): update tailwind generator configuration for Nx 18 #891

Merged

Conversation

luishcastroc
Copy link
Contributor

@luishcastroc luishcastroc commented Feb 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

There's an Error when creating a new Analog application using latest Nx (18) and choosing tailwind

Closes #

What is the new behavior?

Application should generate properly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 60d843c
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65cb72d407dee00008637df4
😎 Deploy Preview https://deploy-preview-891--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 60d843c
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65cb72d425a4f9000847c14b
😎 Deploy Preview https://deploy-preview-891--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 60d843c
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65cb72d4ff54e00008de9b61
😎 Deploy Preview https://deploy-preview-891--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 60d843c
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65cb72d4ac5ad50008748ed6
😎 Deploy Preview https://deploy-preview-891--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts changed the title fix(create-analog): update tailwind generator configurarion for nx18 fix(nx-plugin): update tailwind generator configuration for Nx 18 Feb 13, 2024
@brandonroberts brandonroberts merged commit bfb0423 into analogjs:main Feb 13, 2024
23 checks passed
@luishcastroc luishcastroc deleted the update-tailwind-generator-nx-18 branch March 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants