Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): extract styleUrls using AST #889

Merged

Conversation

rlmestre
Copy link
Contributor

@rlmestre rlmestre commented Feb 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #876

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 7b01332
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65c94bcaffcf0b0008834895
😎 Deploy Preview https://deploy-preview-889--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 7b01332
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65c94bca120c3500084d770e
😎 Deploy Preview https://deploy-preview-889--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65ca284b37cc55eee3320ca3
😎 Deploy Preview https://deploy-preview-889--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65ca285492c2f4f3e5806d2e
😎 Deploy Preview https://deploy-preview-889--analog-ng-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rlmestre
Copy link
Contributor Author

Not sure what's going on with the build here @brandonroberts

@brandonroberts
Copy link
Member

E2E test failure is unrelated

@brandonroberts brandonroberts merged commit a7d5ff0 into analogjs:main Feb 12, 2024
14 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Can't make styleurl to dynamic route due to regex replacement in compiler
2 participants