perf(vite-plugin-angular): only filter to Angular CDK packages for ESM transform #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
force-pushed
the
perf-vitest-transform
branch
from
a1d930d
to
b6229e6
Compare
brandonroberts
changed the title
brandonroberts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
All packages containing
fesm2022in the filename were transformed to es2016 using esbuild. This causes slower performance when running tests with Vitest in Angular.Closes #
What is the new behavior?
By default, only filenames containing
cdk/fesm2022are transformed using esbuild. This drastically improves performance when running tests with Vitest in Angular, while keeping compatibility with existing tests.Additional files can be added to the transform using the
ssr.noExternalarray in thevite.config.tsbut this satisfies using Angular component harness tests as well as regular unit tests using async/await.Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?