Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): add Vite dev-server/build and Vitest executors #719

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Nx has removed compatibility support for builders, so Angular CLI workspaces using @nx/vite executors is no longer supported.

Closes #

What is the new behavior?

Adds new executors/builders to the @analogjs/platform package

@analogjs/platform:vite-dev-server - Development server using Vite. Replaces @nx/vite:dev-server
@analogjs/platform:vite - Build using Vite. Replaces @nx/vite:build
@analogjs/platform:vitest - Run tests using Vitest. Replaces @nx/vite:test

Adds new executors to the Nx preset and app generator.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit d9f47c2
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/653743199e19d400073fcba7
😎 Deploy Preview https://deploy-preview-719--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit d9f47c2
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65374319945d6e0008ef4b2c
😎 Deploy Preview https://deploy-preview-719--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit d9f47c2
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65374319c19cf5000810f36e
😎 Deploy Preview https://deploy-preview-719--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit ff168ff into main Oct 24, 2023
19 checks passed
@brandonroberts brandonroberts deleted the platform-vite-executors branch October 24, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant