Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro-angular): implement output forwarding on client-side hydrated components #641

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

rlmestre
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Documentation content changes

Which package are you modifying?

  • astro-angular

What is the current behavior?

Component outputs are currently not supported.

What is the new behavior?

Outputs from client-side hydrated Components can be listened to as a custom event using an utility function.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

  • Is [data-analog-id] the best property name for this?
  • Are the caveats for making this work acceptable to release this feature? (only client-side, data attribute required, helper function to abstract some workarounds away)

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 4323d72
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6501f4a64571a1000761ec31
😎 Deploy Preview https://deploy-preview-641--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 4323d72
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6501f4a6754da200085fb03f
😎 Deploy Preview https://deploy-preview-641--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 4323d72
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6501f4a6077e4e000885ef29
😎 Deploy Preview https://deploy-preview-641--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation!

apps/astro-app/src/pages/index.astro Outdated Show resolved Hide resolved
packages/astro-angular/README.md Outdated Show resolved Hide resolved
apps/astro-app/src/pages/index.astro Outdated Show resolved Hide resolved
apps/astro-app/src/pages/index.astro Outdated Show resolved Hide resolved
apps/astro-app/src/pages/index.astro Outdated Show resolved Hide resolved
packages/astro-angular/README.md Outdated Show resolved Hide resolved
packages/astro-angular/README.md Outdated Show resolved Hide resolved
packages/astro-angular/src/client.ts Outdated Show resolved Hide resolved
packages/astro-angular/src/client.ts Show resolved Hide resolved
packages/astro-angular/src/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit 3e836cb into analogjs:main Sep 14, 2023
22 checks passed
@brandonroberts
Copy link
Member

This has been released in version 0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants