fix(nx-plugin): remove dependency of nx-plugin to linter #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I barked up the wrong tree...
The issue stemmed from the nx-plugin being dependent on @nx/linter with the way it was set up. Instead, we are just creating a Nx workspace with the preset, which means the dependency is not installed. We need to import the @nx/linter dependency during runtime to avoid the preset to error out.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Even when forcing the @nx/linter dependency to be installed during the preset the execution fails. This is due to the nx-plugin having a direct
dependency on @nx/linter instead of importing it during runtime.
This time for real:
Closes #567
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I am not sure exactly how to add a test for this?
I thought the e2e test would catch this but it seems like it did not and somehow resolved @nx/linter correctly?
[optional] What gif best describes this PR or how it makes you feel?