feat(vite-plugin-nitro): add support for running hooks during pre-rendering #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endering of routes Enabling ability to pass in functions during post-pre-render to modify pages during build
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…endering of routes Fix type mismatch downstream
brandonroberts
changed the title
brandonroberts
requested changes
Jul 14, 2023
packages/vite-plugin-nitro/src/lib/hooks/post-rendering-hook.ts
Outdated
Show resolved
Hide resolved
…endering of routes Made changes based on comments left in the PR.
brandonroberts
approved these changes
Jul 14, 2023
2 tasks
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
…dering (analogjs#548) Co-authored-by: Q <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling ability to pass in functions during post-pre-render to modify pages during build
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #354
What is the new behavior?
Created a property that allows adding functions to be called after pre-rending during builds.
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?