Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin-nitro): adjust output paths for vercel preset #525

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

goetzrobin
Copy link
Member

@goetzrobin goetzrobin commented Jul 7, 2023

we change the output paths to be in a .vercel folder at the root of the workspace. this allows for zero config to be necessary when deploying analog with vercel

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Need to manually adjust the build output for Vercel preset to use .vercel output API

Closes #491

What is the new behavior?

Vercel presets work with 0 additional config necessary.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Magic

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit e64efeb
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64a8395d5f59e20008db79f3
😎 Deploy Preview https://deploy-preview-525--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit e64efeb
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64a8395da4da8d0008f9a61d
😎 Deploy Preview https://deploy-preview-525--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit e64efeb
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64a8395dba72ce00085a2b67
😎 Deploy Preview https://deploy-preview-525--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

we change the output paths to be in a .vercel folder
at the root of the workspace. this allows for zero config
to be necessary when deploying analog with vercel
@goetzrobin goetzrobin force-pushed the feat-adjust-vercel-output-path branch from 831cb7a to d731cb4 Compare July 7, 2023 15:52
@brandonroberts brandonroberts merged commit 1ec80f0 into main Jul 8, 2023
@brandonroberts brandonroberts deleted the feat-adjust-vercel-output-path branch July 8, 2023 01:37
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: update build directory if preset is Vercel
2 participants