feat(platform): improve nx plugin and add tRPC support #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…mplate adds option to the nx generator to let users add the new trpc client. moves v16 app to use the new ApplicationConfig pattern. improves templates by adding separate templates for tailwind and non tailwind. same for trpc and non trpc.
…aking options optional
…onfig, improve templates peer dependencies for tRPC client are now auto installed if user opts to use trpc in their project. also made minor improvements to make vite.config and tRPC config match. continued to improve styling of template files, but this is still biggest work in progress.
goetzrobin
force-pushed
the
improve-nx-plugin-pt-2
branch
from
762efe1
to
082d043
Compare
this commit adds template pages that can be used in the nx plugin and display the features of analog and some general information. if we like these templates we can also adapt them for create-analog. an example of what the template looks like is also added to the trpc-app.
2 tasks
brandonroberts
requested changes
May 11, 2023
...nx-plugin/src/generators/app/files/template-angular-v16/src/app.config.server.ts__template__
Outdated
Show resolved
Hide resolved
packages/nx-plugin/src/generators/app/lib/add-analog-project-config.ts
Outdated
Show resolved
Hide resolved
packages/nx-plugin/src/generators/app/files/template-angular-v16/src/wait-for.ts__template__
Outdated
Show resolved
Hide resolved
|
Lots of great changes! Some thoughts
|
|
Also, I think branching into two sets of template files would be simpler then lots of if/else weaved into the generator templates |
|
@brandonroberts I removed the features and open-source sections of each template. I added some color and the logo at the top of the page. I moved each page in its own template instead of doing the if/else logic inside a single one. Thanks for the feedback and let me know if it looks good now 😃 |
brandonroberts
approved these changes
May 11, 2023
brandonroberts
changed the title
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
So far you had to manually install and integrate the tRPC client.
Issue Number: N/A
What is the new behavior?
This adds a prompt that allows you to
configure the tRPC client out of the box.
Does this PR introduce a breaking change?
Other information
The next step is to come up with much better looking templates for the starters.
Things to consider are:
Also worth adding might be the blog starter