Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): allow dynamic routes in the root route array #381

Merged
merged 1 commit into from
May 10, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Routes with dynamic params defined at the root of the pages directory aren't recognized

Closes #367

What is the new behavior?

Routes with dynamic params defined at the root of the pages directory are recognized.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit bf973d4
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/645b93391441bb000835fa70
😎 Deploy Preview https://deploy-preview-381--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts brandonroberts changed the title fix: allow dynamic routes in the root route array fix(router): allow dynamic routes in the root route array May 10, 2023
@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit bf973d4
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/645b933924a0a40008e53977
😎 Deploy Preview https://deploy-preview-381--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit bf973d4
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/645b9339c041c50007e35200
😎 Deploy Preview https://deploy-preview-381--analog-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@goetzrobin goetzrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brandonroberts brandonroberts merged commit c5ef38e into main May 10, 2023
@brandonroberts brandonroberts deleted the fix-root-dynamic-route branch May 10, 2023 13:40
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ability to handle routes like :category/:topic without having to prefix with a parent path
2 participants