Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): display error overlay in SSR mode #375

Merged
merged 1 commit into from
May 6, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

When a compilation error occurs, the dev server stops

Issue Number: N/A

What is the new behavior?

When a compilation error occurs, the dev server continues running and displays the error overlay

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented May 6, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit de74b5b
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6455a3c234b6870007a7edb4
😎 Deploy Preview https://deploy-preview-375--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 6, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit de74b5b
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6455a3c29de4a400089c632c
😎 Deploy Preview https://deploy-preview-375--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 6, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit de74b5b
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6455a3c33b4e600008077fa5
😎 Deploy Preview https://deploy-preview-375--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts brandonroberts merged commit 3af5ab3 into main May 6, 2023
@brandonroberts brandonroberts deleted the fix-ssr-error-overlay branch May 6, 2023 01:05
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant