feat: make nx plugin work without angular preset and add tailwind option #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| const parsedTags = options.tags | ||
| ? options.tags.split(',').map((s) => s.trim()) | ||
| : []; | ||
| const offsetFromRoot = determineOffsetFromRoot(projectRoot); | ||
|
|
||
| const nxPackageNamespace = major(nxVersion) >= 16 ? '@nx' : '@nrwl'; |
There was a problem hiding this comment.
Let's just use @nx as we'll pin everything to Nx 16.1.0 to support Angular >= v15
There was a problem hiding this comment.
The one thing I want to mention is that this is version comes from the user's Nx workspace. If I understand this correctly removing this logic would mean that we do not support workspaces that have an Nx version of 15
There was a problem hiding this comment.
Good point. Let's keep them separate
There was a problem hiding this comment.
I tested with a v15.9.2 workspace and the current approach & versions for V15 worked 👍
brandonroberts
approved these changes
May 5, 2023
The nx plugin now works without any manual addition of @nx/angular. You can create an empty workspace and simply add the @analogjs/platform dependency. After installing it you can run one command: nx g @analogjs/platform:app. This will automatically install all angular and analog dependencies. This plugin should also work as a preset for npx create-workspace. Since e2e testing for nx plugins is still a bit messy I tested this manually for now. It worked as expected for an empty package based and an empty integrated workspace as well as for an already preconfigured angular workspace.
goetzrobin
force-pushed
the
improve-nx-plugin
branch
from
d2a7028
to
74b90a2
Compare
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nx plugin now works without any manual addition of @nx/angular. You can create an empty workspace and simply add the @analogjs/platform dependency. After installing it you can run one command: nx g @analogjs/platform:app. This will automatically install all angular and analog dependencies. This plugin should also work as a preset for npx create-workspace. Since e2e testing for nx plugins is still a bit messy I tested this manually for now. It worked as expected for an empty package based and an empty integrated workspace as well as for an already preconfigured angular workspace.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Nx plugin required you to have your workspace already configured with angular.
Issue Number: #320
What is the new behavior?
This PR makes the analog plugin take care of all the config. It also makes the Nx plugin
compatible with npx create-nx-workspace presets. (need to verify this after publishing to npm)
It also adds support for setting up tailwind
Does this PR introduce a breaking change?
Other information
I wouldn't consider this completing #320 because we still need to update the Docs and integrate a SPARTAN setup.
I'd like to have all this working before writing the docs to make them be in sync from the get go :)