Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): use JavaScript transformer from Angular Devkit for build optimizations #1302

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Aug 28, 2024

PR Checklist

Closes #

What is the new behavior?

  • Switches to use the JavascriptTransformer from the Angular DevKit (Private API) to prod build optimizations
  • Fixes an issue when importing NgModules like CommonModule or FormsModule not working at runtime because its declarations were stripped out during the build.
  • Fixes an issue with not being able to use self-closing tags for components

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 144bab0
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66cf39db4a22120008cc75da
😎 Deploy Preview https://deploy-preview-1302--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 144bab0
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66cf39dc5d524000089fb053
😎 Deploy Preview https://deploy-preview-1302--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 144bab0
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66cf39dba275c500086e3f9e
😎 Deploy Preview https://deploy-preview-1302--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 144bab0
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66cf39db42a4640008ade967
😎 Deploy Preview https://deploy-preview-1302--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 46da68a into beta Aug 28, 2024
24 checks passed
@brandonroberts brandonroberts deleted the fix-plugin-optimizer branch August 28, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant