Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): add vitest types in tsconfig.spec.json #1197

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

gultyayev
Copy link
Contributor

Add "vitest/globals" to types, and remove jest from the existing types.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

When the tsconfig.spec.ts is updated the types are missing "vitest/globals" type which leads to in-editor errors.

What is the new behavior?

  1. The "vitest/globals" is added to the list of types
  2. The type "jest" is removed from the array if it was previously there (a small improvement of life when migrating)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Add "vitest/globals" to types, and remove jest from the existing types.
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 3a2263c
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66844b0139e28300082825d6
😎 Deploy Preview https://deploy-preview-1197--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 3a2263c
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66844b013c91590008e02c2f
😎 Deploy Preview https://deploy-preview-1197--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 3a2263c
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66844b0105ec8500080e5eab
😎 Deploy Preview https://deploy-preview-1197--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 3a2263c
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66844b0143fd9b0008daa7b9
😎 Deploy Preview https://deploy-preview-1197--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts changed the title feat(platform): handle types in spec.ts fix(nx-plugin): add vitest types in tsconfig.spec.json Jul 2, 2024
@brandonroberts brandonroberts merged commit acaf6dc into analogjs:beta Jul 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants