Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): add error message when default export is missing from component #1194

Merged

Conversation

andersonmfjr
Copy link
Contributor

@andersonmfjr andersonmfjr commented Jul 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #1129

What is the new behavior?

Show a console.warn when default export is missing from component

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 28c603d
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66844fa1c4e8fa0008337c9c
😎 Deploy Preview https://deploy-preview-1194--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 28c603d
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66844fa1c64e5500088466dd
😎 Deploy Preview https://deploy-preview-1194--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 28c603d
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66844fa1c43bd30008f6ba66
😎 Deploy Preview https://deploy-preview-1194--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andersonmfjr andersonmfjr changed the base branch from main to beta July 2, 2024 16:06
@andersonmfjr andersonmfjr changed the title feat(router): adds error message when default export is missing from component feat(router): add error message when default export is missing from component Jul 2, 2024
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 28c603d
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66844fa1c5d0220008c2a033
😎 Deploy Preview https://deploy-preview-1194--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andersonmfjr andersonmfjr marked this pull request as draft July 2, 2024 16:09
packages/router/src/lib/routes.ts Outdated Show resolved Hide resolved
packages/router/src/lib/routes.ts Outdated Show resolved Hide resolved
@brandonroberts brandonroberts changed the title feat(router): add error message when default export is missing from component fix(router): add error message when default export is missing from component Jul 2, 2024
@brandonroberts brandonroberts merged commit 4d33677 into analogjs:beta Jul 2, 2024
24 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @andersonmfjr for code

Copy link
Contributor

@brandonroberts

I've put up a pull request to add @andersonmfjr! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error message when xx.page.ts does not have a default export
2 participants