Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-nitro): produce consistent builds for CSR mode #1011

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Apr 6, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

When setting ssr: false in the analog plugin config, the client build output isn't produced in the dist/analog/public folder.

Closes #

What is the new behavior?

  • When setting ssr: false in the analog plugin config, the client build output is still produced in the dist/analog/public folder by default.
  • Prerendered routes are rendered as CSR-only HTML files.
  • Running the built server serves the app with a fallback to CSR-only mode.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 9eee378
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6611fafe9678090008eba208
😎 Deploy Preview https://deploy-preview-1011--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 9eee378
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6611fafe5cbcd5000808fa7a
😎 Deploy Preview https://deploy-preview-1011--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 9eee378
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/6611fafed95181000857bd9c
😎 Deploy Preview https://deploy-preview-1011--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 9eee378
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6611fafea451550008cf8881
😎 Deploy Preview https://deploy-preview-1011--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit d97dceb into beta Apr 8, 2024
23 checks passed
@brandonroberts brandonroberts deleted the fix-csr-build branch April 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant