iio_attr: after automaticed testing, make return codes consistant. #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After putting together some automated tests for iio_attr (which I will check in later), fix some inconsistancies in iio_attr, which makes the return codes return error on errors, and success on a success. Split up reporting of buffers, to make it easier to find scan, input and output buffers. Now you can see things like this: rgetz@brain:~/github/libiio/build$ ./tests/iio_attr -a usb -i -o -s -c Using auto-detected IIO context at URI "usb:3.49.5" IIO context has 5 devices: iio:device0, adm1177: found 0 scan, 0 output, 2 input channels iio:device1, ad9361-phy: found 0 scan, 5 output, 4 input channels iio:device2, xadc: found 0 scan, 0 output, 10 input channels iio:device3, cf-ad9361-dds-core-lpc: found 2 scan, 6 output, 0 input channels iio:device4, cf-ad9361-lpc: found 2 scan, 0 output, 2 input channels Which makes it easier to understand a device. Signed-off-by: Robin Getz <[email protected]>
dNechita
approved these changes
Jun 4, 2020
dNechita
added a commit
that referenced
this pull request
Jun 5, 2020
Changelog: 4a35451 tests: update the help printed out with -h beda517 iio_utils: tweak context creation to split things better 0904524 iio_attr: change verbosity of output 732bf79 man: update iio_attr man page ac92604 dox: update the mainpage of the generated dox 0330da4 libiio.iss.cmakein: Drop the "ignoreversion" flag and use the "replacesameversion" flag instead. bbc9411 cmake: add gcov support for looking at test coverage b69fb03 iio_utils: rework/fix command line argument parsing ec3b7ed iio_attr: after automaticed testing, make return codes consistant. b87c71d Coverity: Now we have optional flags, make sure to validate optarg c9250c0 coverity: Fix Sizeof not portable (SIZEOF_MISMATCH) bae0e60 usb.c : Simplify the "usb:" context scanning edef5b9 python: iio_info.py rewrite. 7657cef usb.c: change a cast that was causing a problem on MSVC. 52a524b doc: added Sphinx documentation for iio_attr.py. 3f18c3a python: added iio_attr with Python bindings. 1172c7e iio_attr: enable code gen for local contexts 71bdda5 xml: Add capability to properly encode xml entities in context attributes 53c4add iio_utils: now that we support backend filtering, do so. d532845 scan context: allow mutltiple backends for scanning context c04042d python: point to the new README.md 8d8c76c MSVC 2019: Fix some minor errors pointed out by MSVS 2019 fdbfe59 cmake: add -Wno-unused-function to dns_sd_windows.c d0aa9c7 cmake: when building, tell people if serial support exists 3447e2f CMakeLists.txt: Add File Version to the file properties. 41aaf1b libiio.iss.cmakein: Ignore FILE VERSION when installing libiio on Windows. d9acea5 csharp: added bindings for context scanning. a0a9367 csharp: added missing bindings. 7b5a7c9 dnssd: added windows implementation with mdns.h 605baa9 coverity: fix resource leak (uri not free()'ed) in network.c 3267944 coverity: handle strto[*] functions under|over-flows robustly 9bfe89c local: add some more info to local scan contexts 6d66318 usb: Fix compile error caused by unkown indentifier (interface) 7779fcd uri context attribute: add it, so the app doesn't need to keep track 3b9e5e1 usb.c : avoid using 'interface' as an identifier. 6a07dd2 context attributes: allow identical keys to over-write eachother 3c816c2 appveyor.yml: Fix MSYS2 pacman install. Don't use the latest version. 90b6e92 usb uri: add shorthand to the doc c1ad912 usb: if blank usb uri (eg 'usb:'), search for one, and use that 4c577b3 Flawfinder : remove atol and atof, replace with strtoll and strtof e306929 pylint & pep257: Resolve issues in python coding style. 505fffd appveyor.yml: Fix msys update which crashes after a new msys-runtime-devel package update. eda1e62 pep257: turn off D402 checking 008a099 iio_info.py: update to black and fix pylint issues 7b112c7 black: apply black to iio_readdev.py & iio_writedev.py 3a02317 pylint: fix issues in iio_readdev.py and iio_writedev.py ed8f90a python: python examples rewrite 47444bf pylint: turn off some checks 120247b iio_attr: add error checking aeedb21 serial: support defining number of stop bits in serial URI 8a959b9 html: Remove repetitive words d4e517e html: tweak html output to keep track of versions easier. 66b05fa iio.h: fix typo in doc parameter section for one function 86804ec travis-CI: When building doc, make sure the build stops on doc errs 27eaac3 sphinx: add '-w file' (Write warnings (and errors) to the given file) 670af70 dns_sd: qualify IIO_ERROR message before it prints out ee2e9af cppcheck: fix null ptr dereference 7448b35 Enforce method implementation in bindings 817d875 remove usleep(): usleep() is considered obsolete, move to nanosleep() 7654992 tests: add a common function to parse and create iio_contexts e2ab5f4 Cmake: move where -Werrors are turned on in the Cmake a0b6944 iio.py : make some minor tweaks to fix syntax/linting errs df494cd PyLint: add default RC file for PyLint 8c9e24c python: apply settings from black for formatting 50974b3 Remove remaining MATLAB bits from CI intrastructure b6b2354 Add 'Introduced in version' comment to block funcs ea0d5f2 Remove iio-wrapper include from iio-private.h b968f81 Remove WITH_MATLAB_BINDINGS_API defines 098285c Cleanup MATLAB bindings CMake bc7b11f Move scan_block functions into iio.h 091f970 Remove old MATLAB bindings mfiles ad526d9 python: added README.md file for Python bindings. 886b643 iio_common: fix an off by one that was introduced during 9a00766 3f69133 iio_attr: make dealing with devices with no name easier. 4ca68fe fix issues pointed out by no-sign-compare removal 15bba24 Cmake : remove Wno-sign-compare, so we warn on sign diffences 4fcba7d local.c: fix off by one introduced in 3f305ee 9a00766 tests: fix minor issues/errors pointed out by Microsoft Studio 282c10d Fix minor issues/errors pointed out by Microsoft Studio in casting 19522e0 Win: move to safe version of sscanf 2e400fa getenv : keep Windows happy by using _dupenv_s rather than getenv 2e9d236 cmake: Add MSVC flags for Wall, Wno-sign-compare and Werror 9ee8c7f cmake: Restructure CMake CFLAGS for clang e597dcc appveyor.yml: Upgrade packages and pacman before trying to install any dependencies. bb7814b codespell: Fix various spelling mistakes with codespell 13f0360 python: added Channel.convert_inverse(). 848f9f9 python: fixed Channel.convert() method. 06060b8 doc: added DeviceBufferAttr and DeviceDebugAttr in Sphinx. 3fd6a12 cmake: now we are compiling without warnings on macos, make them errors 524a471 iio_stresstest: for macos add back <sys/sysctl.h> 2eb2011 travis-ci: install ncurses and cdk on macos bd26c74 examples: Now we are building on MAC, fix the header include 8a5d43b Travis-CI: Update OSX building to the same as Linux 275b65f iio_info: fix scanning ab6581f Coverity: Fix potential divide by zero in iio_readdev 7f0bcd0 Coverity: points out that the normal return path does a double free a613dd0 Codacy: replace remaining sprintf in iio-monitor 282b0dd csharp: Control Structures should use curly braces {} af1622d Coverity: Remove remaining asserts that were not caught 0b3949d Cmake: Turn on -Werror for CI system 8d7fd52 iio_stresstest: was including <sys/sysctl.h> by accident. 88b946f iio-monitor: Now the c90 warnings are gone, fix real warnings b58cc88 Coverity: 'IIO_ASSERT' falsely flags just like 'ASSERT' does. Change it. a330cc1 cmake: support old Cmake for -std=c99 3f305ee replace strcpy and snprintf in remaining user in libiio db72b73 iiod-client.c: rework iiod_client_open_unlocked to remove strcpy 74d298e examples: Rename ASSERT to iio_ASSERT 973c61c iio-monitor: fix Argument cannot be negative b31fc3e examples: Improved error handling when malloc or calloc fails. a0343f3 xml buildups: fix bug introduced by recent changes 0c60091 Prospector: turn off pylint 6e69115 Revert "Cmake/Coverity: Force coverity to check _everything_" 71a5b00 Coverity: Fix potential divide by zero. 53d83cc prospector: add a configuration file for prospector 262b039 flawfinder : sprintf doesn't check for buffer overflows. 882568b Cmake/Coverity: Force coverity to check _everything_ 8f87367 Cmake: remove unused defintions in Cmake a51b8bb flawfinder: mark some ignores for CWE-134 in debug.h 1fa3040 context.c: optimize buidling xml function 55842bf device.c: optimize building xml function 945407c channel.c: optimize buidling xml function fde81b1 context.c: remove strcpy & sprintf, and move to safe functions 2f55cd4 device.c : remove strcpy & sprintf, and move to safe functions 1e91e5d channel.c: remove strcpy & sprintf, and move to safe functions 474c708 utilities.c: add an iio_strlcpy, a "safer" version of strncpy 36204e2 context.c : track length of buffer when buidling xml 8c83eae device.c track length of buffer when buidling xml eed04bd channel.c: track length of buffer when buidling xml 590baea Codacy fixes. 9b13564 python: added missing Python bindings. a18d130 examples: fix issues that were pointed out on the CI 7a8fbe2 CI (travis-ci and coverity) : turn the examples on f69ac5f examples/cmake : Add a cmake to the examples directory 5c66cc2 test: use a common function for printing usage. 503fa9b tests: use sanitize_clamp to qualify all command line input 2dc2bcc cmake: man: Avoid installing empty directories 4017a50 cmake: Fix installation of html documentation 1bf5d6a C#: Add autogenerated Doxygen for C# bindings 9a14cc5 C#: Document missing c# class/methods 5fb5d4a main libiio api doc: Add "back" url at the top of the mainpage bb2020a Doxyfile.in: capture warnings when creating libiio api doc f99017d sphinx: set up the examples so they show up in the generated doc 9960759 gitignore: add conf.py to gitignore 8daedce cmake: Add top level html index file to build system 3b774a2 html doc: add master index file for doc. 329352a tests: put common/replicated functions into a single file 9d88efd gitignore: don't ignore directories named "html" f27fc31 travis-ci: install man2html and turn on man pages in CI 7a75179 htmldoc: add CMake to use man2html to create html doc from man pages eb9fe23 python: code quality improvements 528345b Codacy (shellcheck): Double quote to prevent globbing and word splitting. 942b57d tests: iio_writedev: don't close the buffer on path with EXIT_SUCCESS d957407 tests: iio_writedev: print error regardless of 'app_running' e6c51ea coverity: iio_stresstest : fix Untrusted value as argument (TAINTED_SCALAR) edb0164 Create Contributors.md 4315182 coverity: fix Untrusted value as argument in iio_stresstest bc061a0 converity: fix Argument cannot be negative in libini 293d99c python: Added .rst files for sphinx. 2cd5a0f python: added documentation for iio_readdev and iio_writedev. d28dd36 python: added iio_writedev with Python bindings. 374050c python: added iio_readdev with Python bindings. 0c6f646 bindings/csharp/CMakeLists.txt: Fix install step for CSharp bindings. 7d39af6 coverity: fix Unchecked return value from library e12120a Coverity: fix Call to function atoi with tainted argument 23ab5d8 coverity: fix : Resource leak (RESOURCE_LEAK) dbc2338 libini: Now that we have it, use it. 5950980 README_BUILD : add note about order of operations 746b57f Centos: Centos 6 doesn't support sphinx properly 30bec38 travis-ci: sphinx needs to have things in path d52f8cd travis-CI: Install sphinx on the platforms that need it 88cf702 Cmake: build python bindings doc (sphinx) 33b1f15 Cmake: Make sure bindings are installed after doc 7420fb0 Initial commit for python bindings doc 77568c7 libini : Add this directly to the repo 8188c16 fix #425: add IIO_ prefix to INFO, WARN, DEBUG and ERROR macros ebefefd codacy: fix %d in string requires 'int' but argument is 'unsigned int'. d7c6451 codacity: fix buffer.c: struct member 'callback_wrapper_data' is never used. 4f0bcc7 Doxygen: put results in a version'ed subdirectory 1eadf73 ci,build: add CentOS 8 docker build 7567322 ci,build: add helper to check CentOS min version 1b5bae4 ci,build: let OS_VERSION propagate as env-var 0e69d57 coverity: fix contex.c Untrusted value as argument eb99f04 coverity: fix iiod.c Unchecked return value from library e284750 coverity: fix dns_sd.c Resource leak 332ecdb coverity: fix dns_sd.c Read from pointer after free 3a667fa coverity: fix dns_sd_avahi (Resource leak) 9ba5de1 ci,build: add Ubuntu 20.04 docker builds a537703 ci,build: un-dockerize bionic build 7e1c0bc ci,build: export DEBIAN_FRONTEND=noninteractive when installing apt packages e47caad ci,build: add version checker helpers 4ccfb5b This is a small tweak to try to reduce the travis-ci noise 5a64b64 ci,build: add generic mechanism for passing some Travis-CI envs 63f4488 kernel kernel's headers against libiio headers in CI 6f7ae64 ci,build: split trigger-next-build into it's own stage 7be55fb network scan : add network scan 30209db DNSSD: Increase DNS Service Discovery robustness a2e5814 examples: Add -Wextra & -pedantic-errors to the example Makefile f27f04f iio_writedev: Skip input channels bb3b072 iio_readdev: Skip output channels ee7d71f iio_writedev: Fix copy&paste error in size parameter help 4008b09 Doxygen: add examples to our Doxygen 0d107b1 iio.service file : remove since iiod now announce automatically f7313ce iiod: allow multiple "iio" services to be published on DNS-SD b9acd57 README_BUILD.md : update with a few more Prerequisites 9501cb9 Cmake : move HAVE_DNS_SD to iio-config.h c954463 Fixed on MacOS: - "warning: implicit declaration of function 'sysctlbyname' is invalid in C99" - "error: unknown type name 'u_int'" after including <sys/sysctl.h> 3076542 ci,build: install python-pip for Ubuntu builds 5a6f85f ci,build: split 'make && make package' commands 34f3a99 examples: ensure all examples compile with new return checking option 3037476 add new option and description to man page 5247675 Cmake: restore installing the Avahi service file 98ba731 Update channel type and modifier lists 499a0bc Revert "network: errno should be already negative" 804216a Added Bonjour DNS SD implementation (macOS). d4e1dbc Moved Avahi DNS SD implementation from network.c to dns_sd_avahi.c. 7c633c7 Simplified CMakeLists.txt by using list(APPEND..) efc692a add a stresstest tool for rapid connects and disconnects for iiod b12d050 tests: check return values on all calls bf452ed Add an optional warn_unused_result attribute to functs which return vals 7608823 usb: Add trigger support to the USB backend 69f4d01 iiod-client: errors are negative, so print them that way bb99e5f network: errno should be already negative ef79725 ci,build: drop xcode9 build 1725e42 Remove python bindings from windows installer. Pip will be used instead for all platforms 3ed4840 Update appveyor build to use sdist build instead of bdist_wininst 71cc9cb Add pypi to travis-ci providers for python bindings. Only the first x86 Linux build will push to pypi on tagged commits. 21023a5 Update python bindings installer for pypi packaging. Installer has been updated to support python2 and python3, and will check to see if libiio installed before actually installing the bindings. This is primarily useful for pip users. 87f8f14 usb: be more verbose on errors, by using iio_strerr Adrian Suciu (1): dnssd: added windows implementation with mdns.h Alexandra Trifan (5): bindings/csharp/CMakeLists.txt: Fix install step for CSharp bindings. appveyor.yml: Upgrade packages and pacman before trying to install any dependencies. libiio.iss.cmakein: Ignore FILE VERSION when installing libiio on Windows. CMakeLists.txt: Add File Version to the file properties. libiio.iss.cmakein: Drop the "ignoreversion" flag and use the "replacesameversion" flag instead. AlexandraTrifan (2): appveyor.yml: Fix msys update which crashes after a new msys-runtime-devel package update. appveyor.yml: Fix MSYS2 pacman install. Don't use the latest version. Alexandru Ardelean (12): ci,build: drop xcode9 build ci,build: split 'make && make package' commands ci,build: install python-pip for Ubuntu builds ci,build: split trigger-next-build into it's own stage ci,build: add generic mechanism for passing some Travis-CI envs ci,build: add version checker helpers ci,build: export DEBIAN_FRONTEND=noninteractive when installing apt packages ci,build: un-dockerize bionic build ci,build: add Ubuntu 20.04 docker builds ci,build: let OS_VERSION propagate as env-var ci,build: add helper to check CentOS min version ci,build: add CentOS 8 docker build Cristi Iacob (16): python: added iio_readdev with Python bindings. python: added iio_writedev with Python bindings. python: added documentation for iio_readdev and iio_writedev. python: Added .rst files for sphinx. tests: iio_writedev: print error regardless of 'app_running' tests: iio_writedev: don't close the buffer on path with EXIT_SUCCESS python: code quality improvements python: added missing Python bindings. Codacy fixes. doc: added DeviceBufferAttr and DeviceDebugAttr in Sphinx. python: fixed Channel.convert() method. python: added Channel.convert_inverse(). python: added README.md file for Python bindings. python: added iio_attr with Python bindings. doc: added Sphinx documentation for iio_attr.py. python: iio_info.py rewrite. Dan Nechita (23): Merge pull request #381 from analogdevicesinc/drop-xcode9 Merge pull request #382 from analogdevicesinc/rgetz-network-errno Merge pull request #383 from analogdevicesinc/rgetz-iiod-client-errs-are-negative Merge pull request #385 from analogdevicesinc/rgetz-add-triggers-to-usb-backend Merge pull request #387 from analogdevicesinc/rgetz-add-iio_stresstest Merge pull request #386 from analogdevicesinc/rgetz-warn-when-ignore-return-vals Merge pull request #407 from analogdevicesinc/rgetz-dox-update Merge pull request #409 from larsclausen/iio_readdev_writedev_skip_wrong_channels Merge pull request #427 from analogdevicesinc/rgetz-fix-name-space-collisions Merge pull request #430 from analogdevicesinc/fix-csharp-install Merge pull request #444 from analogdevicesinc/rgetz-remove-strcpy2 Merge pull request #448 from analogdevicesinc/rgetz-flawfinder-sprintf Merge pull request #455 from analogdevicesinc/rgetz-add-prospector-config Merge pull request #465 from analogdevicesinc/rgetz-fix-iio-monitor Merge pull request #493 from analogdevicesinc/rgetz-unncessary-iio-error-message Merge pull request #495 from analogdevicesinc/rgetz-tweak-html-outputs html: Remove repetitive words Merge pull request #512 from analogdevicesinc/rgetz-treat-interface-as-keyword usb: Fix compile error caused by unkown indentifier (interface) Merge pull request #522 from analogdevicesinc/rgetz-cmake-tell-serial Merge pull request #521 from analogdevicesinc/test-installer Merge pull request #541 from analogdevicesinc/rgetz-add-gcov Merge pull request #543 from analogdevicesinc/rgetz-update-some-doc Iacob (2): csharp: added missing bindings. csharp: added bindings for context scanning. Lars-Peter Clausen (3): iio_writedev: Fix copy&paste error in size parameter help iio_readdev: Skip output channels iio_writedev: Skip input channels Marvin Schmidt (2): cmake: Fix installation of html documentation cmake: man: Avoid installing empty directories Matej Kenda (4): Simplified CMakeLists.txt by using list(APPEND..) Moved Avahi DNS SD implementation from network.c to dns_sd_avahi.c. Added Bonjour DNS SD implementation (macOS). Fixed on MacOS: - "warning: implicit declaration of function 'sysctlbyname' is invalid in C99" - "error: unknown type name 'u_int'" after including <sys/sysctl.h> Michael Hennerich (1): Merge pull request #408 from larsclausen/iio_writedev-fix-size-help Petr Štetiar (1): Update channel type and modifier lists Robin Getz (251): usb: be more verbose on errors, by using iio_strerr Merge pull request #377 from analogdevicesinc/rgetz-be-more-verbose-on-usb network: errno should be already negative iiod-client: errors are negative, so print them that way usb: Add trigger support to the USB backend Add an optional warn_unused_result attribute to functs which return vals tests: check return values on all calls add a stresstest tool for rapid connects and disconnects for iiod Revert "network: errno should be already negative" Merge pull request #389 from analogdevicesinc/revert-382-rgetz-network-errno Merge pull request #388 from matejk/gh-307-dns-sd Merge pull request #392 from ynezz/upstream/updates-for-5.4.22 Cmake: restore installing the Avahi service file add new option and description to man page examples: ensure all examples compile with new return checking option Cmake : move HAVE_DNS_SD to iio-config.h README_BUILD.md : update with a few more Prerequisites Merge pull request #404 from analogdevicesinc/rgetz-patch-1 Merge pull request #399 from analogdevicesinc/rgetz-fix-avahi Merge pull request #401 from matejk/macos-build-fixes iiod: allow multiple "iio" services to be published on DNS-SD iio.service file : remove since iiod now announce automatically Doxygen: add examples to our Doxygen Merge pull request #406 from analogdevicesinc/rgetz-allow-more-than-one-iio-on-avahi examples: Add -Wextra & -pedantic-errors to the example Makefile DNSSD: Increase DNS Service Discovery robustness network scan : add network scan Merge pull request #414 from analogdevicesinc/rgetz-fix-examples-codacity-issues kernel kernel's headers against libiio headers in CI Merge pull request #412 from analogdevicesinc/rgetz-dnssd-improvements This is a small tweak to try to reduce the travis-ci noise coverity: fix dns_sd_avahi (Resource leak) coverity: fix dns_sd.c Read from pointer after free coverity: fix dns_sd.c Resource leak coverity: fix iiod.c Unchecked return value from library coverity: fix contex.c Untrusted value as argument Doxygen: put results in a version'ed subdirectory Merge pull request #423 from analogdevicesinc/rgetz-coverity-fixes codacity: fix buffer.c: struct member 'callback_wrapper_data' is never used. codacy: fix %d in string requires 'int' but argument is 'unsigned int'. fix #425: add IIO_ prefix to INFO, WARN, DEBUG and ERROR macros Merge pull request #424 from analogdevicesinc/rgetz-codacy-fixes libini : Add this directly to the repo Cmake: Make sure bindings are installed after doc Cmake: build python bindings doc (sphinx) travis-CI: Install sphinx on the platforms that need it travis-ci: sphinx needs to have things in path Centos: Centos 6 doesn't support sphinx properly README_BUILD : add note about order of operations libini: Now that we have it, use it. coverity: fix : Resource leak (RESOURCE_LEAK) Coverity: fix Call to function atoi with tainted argument coverity: fix Unchecked return value from library Merge pull request #426 from analogdevicesinc/rgetz-coverity-fixes2 Merge pull request #393 from analogdevicesinc/python-doc Merge pull request #428 from analogdevicesinc/rgetz-add-libini converity: fix Argument cannot be negative in libini Merge pull request #432 from analogdevicesinc/rgetz-coverity-fix-libini coverity: fix Untrusted value as argument in iio_stresstest Merge pull request #429 from analogdevicesinc/rgetz-coverity-fix3 Create Contributors.md coverity: iio_stresstest : fix Untrusted value as argument (TAINTED_SCALAR) Merge pull request #435 from analogdevicesinc/rgetz-contributors Merge pull request #436 from analogdevicesinc/rgetz-coverity-fix4 Codacy (shellcheck): Double quote to prevent globbing and word splitting. Merge pull request #438 from analogdevicesinc/rgetz-fix-shellcheck-issues Merge pull request #434 from cristi-iacob/python-codacy-fixes htmldoc: add CMake to use man2html to create html doc from man pages travis-ci: install man2html and turn on man pages in CI gitignore: don't ignore directories named "html" tests: put common/replicated functions into a single file html doc: add master index file for doc. cmake: Add top level html index file to build system gitignore: add conf.py to gitignore sphinx: set up the examples so they show up in the generated doc Doxyfile.in: capture warnings when creating libiio api doc main libiio api doc: Add "back" url at the top of the mainpage C#: Document missing c# class/methods C#: Add autogenerated Doxygen for C# bindings Merge pull request #433 from analogdevicesinc/rgetz-add-man-to-html-doc tests: use sanitize_clamp to qualify all command line input test: use a common function for printing usage. examples/cmake : Add a cmake to the examples directory CI (travis-ci and coverity) : turn the examples on examples: fix issues that were pointed out on the CI Merge pull request #440 from analogdevicesinc/rgetz-utils-work Merge pull request #437 from marv/mandir-empty-cmake-dir channel.c: track length of buffer when buidling xml device.c track length of buffer when buidling xml context.c : track length of buffer when buidling xml utilities.c: add an iio_strlcpy, a "safer" version of strncpy channel.c: remove strcpy & sprintf, and move to safe functions device.c : remove strcpy & sprintf, and move to safe functions context.c: remove strcpy & sprintf, and move to safe functions channel.c: optimize buidling xml function device.c: optimize building xml function context.c: optimize buidling xml function Merge pull request #443 from cristi-iacob/python-bindings flawfinder: mark some ignores for CWE-134 in debug.h Cmake: remove unused defintions in Cmake Cmake/Coverity: Force coverity to check _everything_ flawfinder : sprintf doesn't check for buffer overflows. Merge pull request #447 from analogdevicesinc/rgetz-rgetz-debug.h Merge pull request #451 from analogdevicesinc/rgetz-remove-unused-cmake prospector: add a configuration file for prospector Coverity: Fix potential divide by zero. Merge pull request #456 from analogdevicesinc/rgetz-fix-iio_writedev Merge pull request #453 from analogdevicesinc/rgetz-force-coverity-to-turn-on-options Revert "Cmake/Coverity: Force coverity to check _everything_" Merge pull request #458 from analogdevicesinc/revert-453-rgetz-force-coverity-to-turn-on-options Prospector: turn off pylint xml buildups: fix bug introduced by recent changes examples: Improved error handling when malloc or calloc fails. iio-monitor: fix Argument cannot be negative examples: Rename ASSERT to iio_ASSERT Merge pull request #459 from analogdevicesinc/rgetz-xml-fixups-for-iiod Merge pull request #454 from analogdevicesinc/rgetz-fix-examples iiod-client.c: rework iiod_client_open_unlocked to remove strcpy replace strcpy and snprintf in remaining user in libiio Merge pull request #460 from analogdevicesinc/rgetz-turn-off-prospector-pylint cmake: support old Cmake for -std=c99 Coverity: 'IIO_ASSERT' falsely flags just like 'ASSERT' does. Change it. iio-monitor: Now the c90 warnings are gone, fix real warnings iio_stresstest: was including <sys/sysctl.h> by accident. Cmake: Turn on -Werror for CI system Merge pull request #463 from analogdevicesinc/rgetz-assert-to-ensure Merge pull request #461 from analogdevicesinc/rgetz-fix-remaining-snprintf-issues Coverity: Remove remaining asserts that were not caught Merge pull request #464 from analogdevicesinc/rgetz-remove-asserts Merge pull request #462 from analogdevicesinc/rgetz-makec99-on-old-cmake csharp: Control Structures should use curly braces {} Codacy: replace remaining sprintf in iio-monitor Coverity: points out that the normal return path does a double free Coverity: Fix potential divide by zero in iio_readdev iio_info: fix scanning Merge pull request #470 from analogdevicesinc/rgetz-fix-iio-info-scanning Merge pull request #467 from analogdevicesinc/rgetz-fix-csharp-formatting-issues Merge pull request #466 from analogdevicesinc/rgetz-fix-coverity-iio-readdev Travis-CI: Update OSX building to the same as Linux examples: Now we are building on MAC, fix the header include travis-ci: install ncurses and cdk on macos iio_stresstest: for macos add back <sys/sysctl.h> cmake: now we are compiling without warnings on macos, make them errors Merge pull request #452 from cristi-iacob/python-doc-deviceattr codespell: Fix various spelling mistakes with codespell Merge pull request #469 from analogdevicesinc/rgetz-update-osx-builds Merge pull request #473 from analogdevicesinc/rgetz-codespell Merge pull request #476 from analogdevicesinc/appveyor-curl-fix cmake: Restructure CMake CFLAGS for clang cmake: Add MSVC flags for Wall, Wno-sign-compare and Werror getenv : keep Windows happy by using _dupenv_s rather than getenv Win: move to safe version of sscanf Fix minor issues/errors pointed out by Microsoft Studio in casting tests: fix minor issues/errors pointed out by Microsoft Studio local.c: fix off by one introduced in 3f305ee Merge pull request #475 from analogdevicesinc/rgetz-add-flags-to-clang Merge pull request #480 from analogdevicesinc/rgetz-fix-off-by-one Merge pull request #472 from analogdevicesinc/rgetz-update-win-builds Cmake : remove Wno-sign-compare, so we warn on sign diffences fix issues pointed out by no-sign-compare removal iio_attr: make dealing with devices with no name easier. iio_common: fix an off by one that was introduced during 9a00766 Merge pull request #468 from analogdevicesinc/rgetz-dont-ignore-sign-differences Merge pull request #482 from analogdevicesinc/rgetz-iio-attr-triggers Merge pull request #483 from cristi-iacob/python-readme Remove remaining MATLAB bits from CI intrastructure Merge pull request #477 from analogdevicesinc/tcollins-merge-matlab-header python: apply settings from black for formatting PyLint: add default RC file for PyLint iio.py : make some minor tweaks to fix syntax/linting errs Cmake: move where -Werrors are turned on in the Cmake Merge pull request #490 from analogdevicesinc/rgetz-shuffle-Cmake-to-avoid-Werror tests: add a common function to parse and create iio_contexts remove usleep(): usleep() is considered obsolete, move to nanosleep() Merge pull request #484 from analogdevicesinc/rgetz-use-black Merge pull request #489 from analogdevicesinc/rgetz-tests-common-context-creation Merge pull request #491 from analogdevicesinc/rgetz-move-to-nanosleep cppcheck: fix null ptr dereference dns_sd: qualify IIO_ERROR message before it prints out sphinx: add '-w file' (Write warnings (and errors) to the given file) travis-CI: When building doc, make sure the build stops on doc errs iio.h: fix typo in doc parameter section for one function html: tweak html output to keep track of versions easier. Merge pull request #494 from analogdevicesinc/rgetz-make-doc-errs-fail-on-CI Merge pull request #496 from analogdevicesinc/dnechita-fix-mainpage-doc Merge pull request #492 from analogdevicesinc/rgetz-fix-null-ptr-deref-in-tests serial: support defining number of stop bits in serial URI Merge pull request #498 from analogdevicesinc/rgetz-serial-support-stop-bits iio_attr: add error checking pylint: turn off some checks Merge pull request #500 from analogdevicesinc/rgetz-iio-attr-add-err-checking Merge pull request #501 from analogdevicesinc/rgetz-tweak-pylint python: python examples rewrite pylint: fix issues in iio_readdev.py and iio_writedev.py black: apply black to iio_readdev.py & iio_writedev.py Merge pull request #503 from analogdevicesinc/rgetz-rework-pythond-examples iio_info.py: update to black and fix pylint issues pep257: turn off D402 checking Merge pull request #504 from analogdevicesinc/rgetz-fix-iio_info.py Merge pull request #505 from analogdevicesinc/fix-msys2 pylint & pep257: Resolve issues in python coding style. Flawfinder : remove atol and atof, replace with strtoll and strtof Merge pull request #502 from analogdevicesinc/rgetz-flawfinder-remove-atol usb: if blank usb uri (eg 'usb:'), search for one, and use that usb uri: add shorthand to the doc Merge pull request #506 from analogdevicesinc/rgetz-resolve-pylint-issues Merge pull request #507 from analogdevicesinc/rgetz-add-search-for-usb-uri Merge pull request #511 from analogdevicesinc/fix-msys2 context attributes: allow identical keys to over-write eachother usb.c : avoid using 'interface' as an identifier. uri context attribute: add it, so the app doesn't need to keep track Merge pull request #509 from analogdevicesinc/rgetz-add-uri-context-attribute Merge pull request #514 from analogdevicesinc/dnechita-fix-usb-compile-err local: add some more info to local scan contexts coverity: handle strto[*] functions under|over-flows robustly Merge pull request #513 from analogdevicesinc/rgetz-add-to-local-scan-info Merge pull request #510 from analogdevicesinc/rgetz-fix-strtol-overflows coverity: fix resource leak (uri not free()'ed) in network.c Merge pull request #515 from analogdevicesinc/rgetz-coverity-fix-resource-leak Merge pull request #508 from analogdevicesinc/dnssd-windows cmake: when building, tell people if serial support exists cmake: add -Wno-unused-function to dns_sd_windows.c MSVC 2019: Fix some minor errors pointed out by MSVS 2019 python: point to the new README.md scan context: allow mutltiple backends for scanning context iio_utils: now that we support backend filtering, do so. Merge pull request #523 from analogdevicesinc/rgetz-fix-MVSC2019 xml: Add capability to properly encode xml entities in context attributes Merge pull request #528 from analogdevicesinc/rgetz-allow-multiple-scan-backends Merge pull request #526 from analogdevicesinc/rgetz-fix-xml-entities iio_attr: enable code gen for local contexts usb.c: change a cast that was causing a problem on MSVC. usb.c : Simplify the "usb:" context scanning Merge pull request #530 from analogdevicesinc/rgetz-fix-local-codegen coverity: Fix Sizeof not portable (SIZEOF_MISMATCH) Coverity: Now we have optional flags, make sure to validate optarg Merge pull request #534 from analogdevicesinc/rgetz-fix-coverity23 Merge pull request #535 from analogdevicesinc/rgetz-fix-winusb iio_attr: after automaticed testing, make return codes consistant. iio_utils: rework/fix command line argument parsing Merge pull request #538 from analogdevicesinc/rgetz-fix-tests Merge pull request #539 from analogdevicesinc/rgetz-test-fixes cmake: add gcov support for looking at test coverage Merge pull request #488 from cristi-iacob/csharp-bindings Merge pull request #544 from analogdevicesinc/fix-ignoreversion dox: update the mainpage of the generated dox man: update iio_attr man page iio_attr: change verbosity of output iio_utils: tweak context creation to split things better tests: update the help printed out with -h Merge pull request #542 from analogdevicesinc/rgetz-change-verbosity-of-iio_attr Travis Collins (6): Update python bindings installer for pypi packaging. Installer has been updated to support python2 and python3, and will check to see if libiio installed before actually installing the bindings. This is primarily useful for pip users. Merge pull request #380 from analogdevicesinc/pip-installer-fixes Merge pull request #422 from cristi-iacob/python-tests Merge pull request #527 from analogdevicesinc/rgetz-fix-python-readme Merge pull request #457 from cristi-iacob/python-iioattr Merge pull request #532 from cristi-iacob/python-iio-info Travis F. Collins (11): Add pypi to travis-ci providers for python bindings. Only the first x86 Linux build will push to pypi on tagged commits. Update appveyor build to use sdist build instead of bdist_wininst Remove python bindings from windows installer. Pip will be used instead for all platforms Initial commit for python bindings doc Remove old MATLAB bindings mfiles Move scan_block functions into iio.h Cleanup MATLAB bindings CMake Remove WITH_MATLAB_BINDINGS_API defines Remove iio-wrapper include from iio-private.h Add 'Introduced in version' comment to block funcs Enforce method implementation in bindings Signed-off-by: Dan Nechita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After putting together some automated tests for iio_attr (which I will
check in later), fix some inconsistancies in iio_attr, which makes the
return codes return error on errors, and success on a success.
Split up reporting of buffers, to make it easier to find scan, input and
output buffers. Now you can see things like this:
rgetz@brain:~/github/libiio/build$ ./tests/iio_attr -a usb -i -o -s -c
Using auto-detected IIO context at URI "usb:3.49.5"
IIO context has 5 devices:
iio:device0, adm1177: found 0 scan, 0 output, 2 input channels
iio:device1, ad9361-phy: found 0 scan, 5 output, 4 input channels
iio:device2, xadc: found 0 scan, 0 output, 10 input channels
iio:device3, cf-ad9361-dds-core-lpc: found 2 scan, 6 output, 0 input channels
iio:device4, cf-ad9361-lpc: found 2 scan, 0 output, 2 input channels
Which makes it easier to understand a device.
Signed-off-by: Robin Getz [email protected]