Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use EventEmitter API to emit events for replay blocks #20

Merged
merged 7 commits into from
Mar 7, 2019

Conversation

PBug90
Copy link
Owner

@PBug90 PBug90 commented Jan 31, 2019

This PR aims to provide better output customization for parser users. It allows to listen for events for any kind of block that exists in the replay hierarchy. In addition, it decouples the basic parser logic in a separate file so that overall complexity of the W3GReplay class is reduced.

  • finish refactoring parser logic into separate file
  • correct the currently disabled typings
  • refactor typings to be less clustered
  • update documentation and example

@PBug90 PBug90 merged commit b476e5d into master Mar 7, 2019
@PBug90 PBug90 deleted the refactor-eventemitter branch April 26, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant