jadeite metadata not checking second link

[EnergoStalin]

Isn't this suppose to check both links and not just error on first one?

game-integrations/games/star-rail/integration.lua

Lines 51 to 63 in 656f8e8

	for _, uri in pairs(uris) do
	if jadeite_metadata ~= nil then
	break
	end
	local response = v1_network_fetch(uri)
	if not response["ok"] then
	error("Failed to request jadeite metadata (code " .. response["status"] .. "): " .. response["statusText"])
	end
	jadeite_metadata = response.json()
	end

Rip codeberg

game-integrations/games/star-rail/integration.lua

Lines 46 to 49 in 656f8e8

	local uris = {
	"https://codeberg.org/mkrsym1/jadeite/raw/branch/master/metadata.json",
	"https://notabug.org/mkrsym1/jadeite-mirror/raw/master/metadata.json"
	}

I come up with this

local function get_jadeite_metadata()
  local uris = {
    "https://codeberg.org/mkrsym1/jadeite/raw/branch/master/metadata.json",
    "https://notabug.org/mkrsym1/jadeite-mirror/raw/master/metadata.json"
  }

  local requests = {}
  for _, uri in pairs(uris) do
    local response = v1_network_fetch(uri)
    table.insert(requests, response)

    if response["ok"] then
      jadeite_metadata = response.json()
      break
    end
  end

  if not jadeite_metadata then
    local msg = "Jadeite metadata requests failed:\n"
    for i, r in ipairs(requests) do
      msg = string.format("%s\n%s (code %s): %s" msg, uris[i], r["status"], r["statusText"])
    end

    error(msg)
  end

  return jadeite_metadata
end

[bcrescimanno]

Regardless of whether it actually checks multiple sources, I'd say the larger issue here is that it results in an application crash which means you can't launch titles that don't depend on jadeite.