fix(types): added name
to format, and export Named
#714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Sorry, haven't raised an issue
Description of changes:
name
toFormat
. On our project we useregisterFormat
which takes an object (Format
) with aformatter
and aname
. However, on switching to the latest version of SD, an error is thrown as the types weren't allowingname
.Named
.registerTransform
takesNamed<Transform>
as an input, yet was not exported from SD as a type, so we weren't able to type these transforms independently. ExportingNamed
allows us to do this.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.