Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): remove blank lines in scss/map-deep and scss/map-flat templates #588

Merged
merged 1 commit into from
Apr 2, 2021
Merged

fix(template): remove blank lines in scss/map-deep and scss/map-flat templates #588

merged 1 commit into from
Apr 2, 2021

Conversation

kseino
Copy link
Contributor

@kseino kseino commented Mar 30, 2021

Issue #, if available: #418

Description of changes: Setting "showFileHeader": false generates two blank lines in scss/map-deep and scss/map-flat files. scss/variables does not generate blank lines. This PR should remove two blank lines.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Reproduction:
config.json

{
  "source": ["properties/**/*.json"],
  "platforms": {
    "scss:variables": {
      "transformGroup": "scss",
      "buildPath": "build/scss/",
      "files": [
        {
          "destination": "variables.scss",
          "format": "scss/variables",
          "options": { "showFileHeader": false }
        }
      ]
    },
    "scss:map-deep": {
      "transformGroup": "scss",
      "buildPath": "build/scss/",
      "files": [
        {
          "destination": "mapdeep.scss",
          "format": "scss/map-deep",
          "options": { "showFileHeader": false }
        }
      ]
    },
    "scss:map-flat": {
      "transformGroup": "scss",
      "buildPath": "build/scss/",
      "files": [
        {
          "destination": "mapflat.scss",
          "format": "scss/map-flat",
          "options": { "showFileHeader": false }
        }
      ]
    }
  }
}

@chazzmoney
Copy link
Collaborator

Thank you for your contribution!

@dbanksdesign dbanksdesign changed the base branch from main to 3.0 April 2, 2021 23:18
@chazzmoney chazzmoney changed the base branch from 3.0 to main April 2, 2021 23:19
@chazzmoney chazzmoney merged commit a88e622 into amzn:main Apr 2, 2021
@kseino kseino deleted the fix-scss-templates branch April 5, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants