fix(parsers): fixed an error where parsers weren't running #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Hi @dbanksdesign, any idea on when this fix will make it to the next rc? Thanks |
|
I just saw #514 (comment), thanks for releasing rc.2 with the fix! |
dbanksdesign
added a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #510
Description of changes: The extend method was sending the wrong parameters to combineJSON so parsers never ran. This came up because of 2 PRs changing the combineJSON method signature. For future sanity we might want to consider changing methods to take a single object.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.