fix(formats): fix max call stack issue on json/nested format #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2020
chazzmoney
reviewed
Sep 30, 2020
| @@ -784,14 +789,14 @@ module.exports = { | |||
| * @example | |||
| * ```dart | |||
| * import 'package:flutter/material.dart'; | |||
| * | |||
chazzmoney
reviewed
Sep 30, 2020
| * class StyleDictionary { | ||
| * StyleDictionary._(); | ||
| * |
chazzmoney
reviewed
Sep 30, 2020
| * static const colorBrandPrimary = Color(0x00ff5fff); | ||
| * static const sizeFontSizeMedium = 16.00; | ||
| * static const contentFontFamily1 = "NewJune"; | ||
| * ``` |
|
LGTM - and you made some whitespace modifications. I'm totally good merging as is, but wanted to make sure you saw them.
|
|
I did not see those whitespace changes... thanks for bringing them up. Let me double check them, maybe it was prettier doing something... |
|
Ah I have the prettier plugin on VSCode and it was removing trailing whitespace. So it's a change we probably should make, but we should also probably have prettier as a dev dependency and have it run as a pre-commit hook or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #464
Description of changes: Fixing max call stack on
json/nestedformat when the dictionary object contains non-token data. The issue was we were usingfor (var name in obj)assumingobjwas an object, but if it was a string it would get in an infinite loop.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.