Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update style-dictionary clean config path #454

Merged
merged 1 commit into from
Oct 8, 2020
Merged

fix: update style-dictionary clean config path #454

merged 1 commit into from
Oct 8, 2020

Conversation

kyh
Copy link
Contributor

@kyh kyh commented Aug 23, 2020

style-dictionary build and style-dictionary clean should use the same default config paths

Description of changes:
Ran into an issue where running style-dictionary build worked but style-dictionary clean threw an error because I was using config.js instead of config.json

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

`style-dictionary build` and `style-dictionary clean` should use the same config path defaults
@kyh kyh changed the title Update style-dictionary Update style-dictionary clean config path Aug 23, 2020
@chazzmoney
Copy link
Collaborator

This looks like a solid bugfix to me - @dbanksdesign is there a reason that the clean would want to use a different method to get configs?

@kyh kyh changed the title Update style-dictionary clean config path fix: update style-dictionary clean config path Sep 30, 2020
Copy link
Member

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dbanksdesign dbanksdesign merged commit 3cc3d4e into amzn:main Oct 8, 2020
dbanksdesign pushed a commit that referenced this pull request Oct 8, 2020
`style-dictionary build` and `style-dictionary clean` were not using the same config path defaults. This fixes that.
@kyh kyh deleted the patch-2 branch October 9, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants