Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new method 'registerFilter' to enable custom filtering #207

Closed
chazzmoney opened this issue Nov 30, 2018 · 2 comments
Closed

Create new method 'registerFilter' to enable custom filtering #207

chazzmoney opened this issue Nov 30, 2018 · 2 comments
Labels
Core Architecture This is an issue related to the core architecture of Style Dictionary enhancement
Milestone

Comments

@chazzmoney
Copy link
Collaborator

From #199:

Define a new registerFilter method in Style Dictionary (similar to what we have with registerFormat, registerTemplate, registerAction) so that we can do:

"filter": "name_of_the_filter"
(in the same way as we do "template": "name_of_template" or "format": "name_of_format").

Then in the filterProperties function declaration we can easily detect if the filter is a "custom" filter by the fact that is a string.

This creates consistency across how we define our configuration (and customizations of it).

@chazzmoney chazzmoney added this to the 3.0 milestone Nov 30, 2018
@chazzmoney chazzmoney added enhancement Core Architecture This is an issue related to the core architecture of Style Dictionary labels Nov 30, 2018
@didoo
Copy link
Contributor

didoo commented Jan 3, 2019

FYI I have started to work on this one.

@chazzmoney
Copy link
Collaborator Author

Added in v2.7.0

Thanks @didoo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Architecture This is an issue related to the core architecture of Style Dictionary enhancement
Projects
None yet
Development

No branches or pull requests

2 participants