Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test: lib/transform/config.js #143

Closed
dbanksdesign opened this issue Oct 1, 2018 · 5 comments
Closed

Add test: lib/transform/config.js #143

dbanksdesign opened this issue Oct 1, 2018 · 5 comments

Comments

@dbanksdesign
Copy link
Member

Note: Work off of the 'jest' branch. That is our new branch to work off of for the testing upgrades. When everything is ready we will merge that branch back into develop and mainline.

@didoo
Copy link
Contributor

didoo commented Jan 19, 2019

@dbanksdesign do you think I can pick up this one after #233 (now I know a little bit more the code in that file) or do you prefer to leave is for first-issues? (personally, I would prefer to see this fully covered, it's an important part of SD).

@dbanksdesign
Copy link
Member Author

Please do!

@chazzmoney
Copy link
Collaborator

Is this now covered? Do we need to flesh out more here?

https://github.com/amzn/style-dictionary/blob/master/__tests__/transform/config.test.js

@dbanksdesign
Copy link
Member Author

I think we are covered now. There can be some more test we can put in later, but I think this is a good start

@chazzmoney
Copy link
Collaborator

Sweet. If there are other tests you want to see added, can you open another issue and I'll add them in?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants