Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for es6 format #140

Closed
dbanksdesign opened this issue Oct 1, 2018 · 5 comments
Closed

Add unit tests for es6 format #140

dbanksdesign opened this issue Oct 1, 2018 · 5 comments

Comments

@dbanksdesign
Copy link
Member

dbanksdesign commented Oct 1, 2018

We are working to have better testing coverage and migrating our tests to Jest from Mocha. With some work, we should be able to test the es6 format, which we have been unable to do because Mocha does not understand es6.

https://github.com/facebook/jest#additional-configuration

Note: Work off of the 'jest' branch. That is our new branch to work off of for the testing upgrades. When everything is ready we will merge that branch back into develop and mainline.

@DarthOstrich
Copy link
Contributor

I've been writing a lot of tests using Jest recently, so I'd like to hop on board here. I'm assuming you want the other issues completed, or are you just looking for a complete overhaul of every single test?

@dbanksdesign
Copy link
Member Author

Sorry @DarthOstrich looks like @davixyz beat you to the punch. One major thing we are doing right now is migrating our tests from Mocha to Jest, which is mostly done, but in the process we want to go through our tests, make sure they are all functioning properly, add tests that should be there, etc. I made a project to track this: https://github.com/amzn/style-dictionary/projects/4

If you want to hop in to our new Jest tests and see if there is anything that could be improved, that would be super helpful. For this project we have a 'jest' branch on the repository we are working off of. Right now on the branch, the previous tests have been migrated, but we are still looking to see where our tests could improve, either by adding more tests where there aren't any yet, or general housekeeping in the testing. We are also keen to add code coverage with Istanbul/NYC as well. If any of that interests you, take a look at the 'jest' branch and let me know what you think. If you have any questions or anything let me know!

@didoo
Copy link
Contributor

didoo commented Oct 3, 2018

@DarthOstrich see the conversation here: #133
there are a few important points that are still open for discussions, and feedback/ideas/contributions are more than welcome :)

@davixyz
Copy link
Contributor

davixyz commented Oct 4, 2018

I think this could be closed with this:
#149

but if we need more testing for this format, definitely leave it open

@dbanksdesign
Copy link
Member Author

Yup I'm going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants