Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support onTransactionWrite with GSI key in InMemoryDynamoDBCompositePrimaryKeyTableWithIndex #100

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

haotianzhu
Copy link
Contributor

Issue #, if available:
DynamoDBCompositePrimaryKeyGSILogic doesn't support transactionWrite

Description of changes:

add onTransactWrite in DynamoDBCompositePrimaryKeyGSILogic and user is able to store GSI keys when mocking transaction calls.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@tachyonics tachyonics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tachyonics tachyonics merged commit f2aa711 into smoke-dynamodb-3.x Jan 9, 2024
7 checks passed
@haotianzhu haotianzhu deleted the haotzhu branch January 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants