Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmokeAWSCredentials in README.md #32

Open
fabianfett opened this issue Nov 3, 2019 · 1 comment
Open

SmokeAWSCredentials in README.md #32

fabianfett opened this issue Nov 3, 2019 · 1 comment

Comments

@fabianfett
Copy link

import SmokeAWSCredentials
...

    guard let credentialsProvider = AwsContainerRotatingCredentials.getCredentials(fromEnvironment: environment) else {
        return Log.error("Unable to obtain credentials from the container environment.")
    }

The README.md has a section about ** Step 4: Instantiate the AWS client for production** as seen above. I can't find bespoken library neither in the master nor in the swift_5_nio_2 branch. Also I can't find AwsContainerRotatingCredentials. Is StaticCredentials from SmokeAWSCore therefore the way to go? If so give me a thumbs up, I will open a PR to update the documentation.

@tachyonics
Copy link
Contributor

It is in a separate repository

The README can probably be made clearer to avoid this understandable confusion if you'd like to open a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants