Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes wrong npm links #2174

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: fixes wrong npm links #2174

merged 2 commits into from
Jul 7, 2023

Conversation

Golodhros
Copy link
Member

Description

Fixes issue with wrong npm package references

Motivation and Context

Solves #2141

How Has This Been Tested?

Built locally

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Jul 7, 2023
@Golodhros Golodhros marked this pull request as ready for review July 7, 2023 22:36
@Golodhros
Copy link
Member Author

@kristenarmes PTAL!

@Golodhros Golodhros mentioned this pull request Jul 7, 2023
Closed
kristenarmes
kristenarmes approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Golodhros Golodhros merged commit bbf29cd into main Jul 7, 2023
@Golodhros Golodhros deleted the mi-npm-link-issues branch July 7, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenarmes kristenarmes kristenarmes approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@ozandogrultan ozandogrultan Awaiting requested review from ozandogrultan ozandogrultan is a code owner

@B-T-D B-T-D Awaiting requested review from B-T-D B-T-D is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Golodhros @kristenarmes